1089260 - crash in java.lang.Exception: Error loading gecko libraries at org.mozilla.gecko.mozglue.GeckoLoader.loadGeckoLibsNative(Native Method)

Reporter

Description

•

10 years ago

This bug was filed from the Socorro interface and is 
report bp-520c3da7-5ee2-4c74-9a2c-428ea2141024.
=============================================================

java.lang.Exception: Error loading gecko libraries
	at org.mozilla.gecko.mozglue.GeckoLoader.loadGeckoLibsNative(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.loadGeckoLibs(GeckoLoader.java:515)
	at org.mozilla.gecko.GeckoThread.initGeckoEnvironment(GeckoThread.java:117)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:171)

#1 on Firefox 36

Richard Newman [:rnewman]

Comment 1

•

10 years ago

This is happening on infra: Bug 1086513.

Blocks: 1086513

Keywords: regressionwindow-wanted

Richard Newman [:rnewman]

Comment 2

•

10 years ago

Might be related to Bug 984366, too.

Aaron Train [:aaronmt]

Reporter

Comment 3

•

10 years ago

Any logcats from these reports?

Flags: needinfo?(mark.finkle)

Richard Newman [:rnewman]

Comment 4

•

10 years ago

http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android/1414240945/mozilla-inbound_panda_android_test-robocop-1-bm100-tests1-panda-build2245.txt.gz

06:47:36     INFO -  10-25 06:47:33.070 I/ActivityManager( 1401): START {act=android.intent.action.MAIN flg=0x10000000 cmp=org.mozilla.fennec/org.mozilla.gecko.BrowserApp (has extras)} from pid 3770
06:47:36     INFO -  10-25 06:47:33.078 I/ActivityThread( 3770): Pub org.mozilla.fennec.profiles: org.mozilla.gecko.GeckoProfilesProvider
06:47:36     INFO -  10-25 06:47:33.078 I/ActivityThread( 3770): Pub org.mozilla.fennec.db.home: org.mozilla.gecko.db.HomeProvider
06:47:36     INFO -  10-25 06:47:33.101 W/NetworkManagementSocketTagger( 1401): setKernelCountSet(10047, 1) failed with errno -2
06:47:36     INFO -  10-25 06:47:33.117 D/GeckoApp( 3770): Enabling Android StrictMode
06:47:36     INFO -  10-25 06:47:33.148 D/GeckoLoader( 3770): Gecko environment env0: MOZ_CRASHREPORTER=1
06:47:36     INFO -  10-25 06:47:33.148 D/GeckoLoader( 3770): env1: XPCOM_DEBUG_BREAK=stack
06:47:36     INFO -  10-25 06:47:33.148 D/GeckoLoader( 3770): env2: MOZ_HIDE_RESULTS_TABLE=1
06:47:36     INFO -  10-25 06:47:33.148 D/GeckoLoader( 3770): env3: MOZ_DISABLE_NONLOCAL_CONNECTIONS=1
06:47:36     INFO -  10-25 06:47:33.148 D/GeckoLoader( 3770): env4: MOZ_CRASHREPORTER_NO_REPORT=1
06:47:36     INFO -  10-25 06:47:33.148 D/GeckoLoader( 3770): env5: MOZ_WIN_INHERIT_STD_HANDLES_PRE_VISTA=1
06:47:36     INFO -  10-25 06:47:33.148 D/GeckoLoader( 3770): env6: NSPR_LOG_FILE=/mnt/sdcard/tests/nspr/nspr-testBookmarksPanel.log
06:47:36     INFO -  10-25 06:47:33.148 D/GeckoLoader( 3770): env7: XPCOM_MEM_BLOAT_LOG=/mnt/sdcard/tests/profile/runtests_leaks.log
06:47:36     INFO -  10-25 06:47:33.148 D/GeckoLoader( 3770): env8: null
06:47:36     INFO -  10-25 06:47:33.148 E/GeckoLibLoad( 3770): Load sqlite start
06:47:36     INFO -  10-25 06:47:33.156 D/GeckoSharedPrefs( 3770): Current version = 1, prefs version = 1
06:47:36     INFO -  10-25 06:47:33.156 W/GeckoLinker( 3770): /data/app/org.mozilla.fennec-1.apk!/assets/libnss3.so: unhandled flags #8 not handled
06:47:36     INFO -  10-25 06:47:33.164 I/SUTAgentAndroid( 1908): onTrimMemory20
06:47:36     INFO -  10-25 06:47:33.164 I/SUTAgentAndroid( 1908): PA:720011264, FREE: 500256768
06:47:36     INFO -  10-25 06:47:33.171 W/GeckoLinker( 3770): /data/app/org.mozilla.fennec-1.apk!/assets/libnss3.so: Relocation to NULL @0x0014ac68
06:47:36     INFO -  10-25 06:47:33.171 I/SUTAgentAndroid( 1908): 10047	3770	org.mozilla.fennec
06:47:36     INFO -  10-25 06:47:33.171 W/GeckoLinker( 3770): /data/app/org.mozilla.fennec-1.apk!/assets/libnss3.so: Relocation to NULL @0x0014afdc for symbol "__cxa_begin_cleanup"
06:47:36     INFO -  10-25 06:47:33.171 W/GeckoLinker( 3770): /data/app/org.mozilla.fennec-1.apk!/assets/libnss3.so: Relocation to NULL @0x0014afe0 for symbol "__cxa_type_match"
06:47:36     INFO -  10-25 06:47:33.179 E/GeckoLibLoad( 3770): Load sqlite done
06:47:36     INFO -  10-25 06:47:33.179 E/GeckoLibLoad( 3770): Load nss start
06:47:36     INFO -  10-25 06:47:33.179 E/GeckoLibLoad( 3770): Load nss done
06:47:36     INFO -  10-25 06:47:33.187 E/GeckoLinker( 3770): Malformed or broken seekable zstream
06:47:36     INFO -  10-25 06:47:33.187 E/GeckoLibLoad( 3770): Couldn't get a handle to libxul!
06:47:36     INFO -  10-25 06:47:33.187 E/GeckoLibLoad( 3770): Throw
06:47:36     INFO -  10-25 06:47:33.203 W/dalvikvm( 3770): threadid=14: thread exiting with uncaught exception (group=0x40b761f8)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 138 ("Gecko")
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770): java.lang.Exception: Error loading gecko libraries
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770): 	at org.mozilla.gecko.mozglue.GeckoLoader.loadGeckoLibsNative(Native Method)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770): 	at org.mozilla.gecko.mozglue.GeckoLoader.loadGeckoLibs(GeckoLoader.java:515)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770): 	at org.mozilla.gecko.GeckoThread.initGeckoEnvironment(GeckoThread.java:117)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770): 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:171)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770): Main thread (1) stack:
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     org.mozilla.gecko.mozglue.ByteBufferInputStream.read(ByteBufferInputStream.java:44)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     java.io.BufferedInputStream.fillbuf(BufferedInputStream.java:168)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     java.io.BufferedInputStream.read(BufferedInputStream.java:309)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     android.graphics.BitmapFactory.nativeDecodeStream(Native Method)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:493)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:549)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     android.graphics.drawable.BitmapDrawable.<init>(BitmapDrawable.java:157)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     org.mozilla.gecko.util.GeckoJarReader.getBitmapDrawable(GeckoJarReader.java:47)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     org.mozilla.gecko.util.GeckoJarReader.getBitmap(GeckoJarReader.java:32)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     org.mozilla.gecko.favicons.Favicons.loadBrandingBitmap(Favicons.java:513)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     org.mozilla.gecko.favicons.Favicons.initializeWithContext(Favicons.java:491)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     org.mozilla.gecko.GeckoApp.onCreate(GeckoApp.java:1257)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     org.mozilla.gecko.BrowserApp.onCreate(BrowserApp.java:440)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     android.app.Activity.performCreate(Activity.java:4465)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1049)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1920)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:1981)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     android.app.ActivityThread.access$600(ActivityThread.java:123)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     android.app.ActivityThread$H.handleMessage(ActivityThread.java:1147)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     android.os.Handler.dispatchMessage(Handler.java:99)
06:47:36     INFO -  10-25 06:47:33.203 E/GeckoCrashHandler( 3770):     android.os.Looper.loop(Looper.java:137)
06:47:36     INFO -  10-25 06:47:33.210 E/GeckoCrashHandler( 3770):     android.app.ActivityThread.main(ActivityThread.java:4424)
06:47:36     INFO -  10-25 06:47:33.210 E/GeckoCrashHandler( 3770):     java.lang.reflect.Method.invokeNative(Native Method)
06:47:36     INFO -  10-25 06:47:33.210 E/GeckoCrashHandler( 3770):     java.lang.reflect.Method.invoke(Method.java:511)
06:47:36     INFO -  10-25 06:47:33.210 E/GeckoCrashHandler( 3770):     com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
06:47:36     INFO -  10-25 06:47:33.210 E/GeckoCrashHandler( 3770):     com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
06:47:36     INFO -  10-25 06:47:33.210 E/GeckoCrashHandler( 3770):     dalvik.system.NativeStart.main(Native Method)
06:47:36     INFO -  10-25 06:47:33.226 D/GeckoScreenOrientation( 3770): updating to new orientation LANDSCAPE_PRIMARY
06:47:36     INFO -  10-25 06:47:33.226 I/ActivityManager( 1401): START {act=org.mozilla.gecko.reportCrash cmp=org.mozilla.fennec/org.mozilla.gecko.CrashReporter (has extras)} from pid 3770

Aaron Train [:aaronmt]

Reporter

Comment 5

•

10 years ago

Can anyone else reproduce this? Why is this all of a sudden skyrocketing on socorro?

Richard Newman [:rnewman]

Comment 6

•

10 years ago

06:47:36     INFO -  10-25 06:47:33.187 E/GeckoLinker( 3770): Malformed or broken seekable zstream

suggests a build/packaging change. Build folks, any ideas?

Flags: needinfo?(nalexander)

Flags: needinfo?(gps)

James Willcox (:snorp) (jwillcox@mozilla.com) (he/him)

Updated

•

10 years ago

Assignee: nobody → snorp

tracking-fennec: ? → +

Gregory Szorc [:gps]

Comment 7

•

10 years ago

glandium and mshal have a better handle on this area than I do.

Flags: needinfo?(mshal)

Flags: needinfo?(mh+mozilla)

Flags: needinfo?(gps)

Mike Hommey [:glandium]

Comment 8

•

10 years ago

There has been no packaging change that could explain that. The only change that could have affected the szip process is bug 1059797 but it landed after the log from comment 4.
Moreover, if there was a packaging problem triggering this, it would cause problems on *all* tests for the given build, not just one.

Flags: needinfo?(mh+mozilla)

Nick Alexander :nalexander [he/him]

Comment 9

•

10 years ago

(In reply to Richard Newman [:rnewman] from comment #6)
> 06:47:36     INFO -  10-25 06:47:33.187 E/GeckoLinker( 3770): Malformed or
> broken seekable zstream
> 
> suggests a build/packaging change. Build folks, any ideas?

I know of nothing that would have changed this.  Further questions in the TBPL bug.

Nick Alexander :nalexander [he/him]

Updated

•

10 years ago

Flags: needinfo?(nalexander)

Michael Shal [:mshal]

Comment 10

•

10 years ago

Is it possible to add more debug? It might be helpful if the "Couldn't get a handle to libxul!" message included the message from dlerror() (if the dlopen wrapper supports that). And the "Malformed or broken seekable zstream" makes 7 different checks - it would be nice to know which one in particular is failing.

Are these messages also real errors or just noise?

1) 06:47:36     INFO -  10-25 06:47:33.156 W/GeckoLinker( 3770): /data/app/org.mozilla.fennec-1.apk!/assets/libnss3.so: unhandled flags #8 not handled

2) 06:47:36     INFO -  10-25 06:47:33.171 W/GeckoLinker( 3770): /data/app/org.mozilla.fennec-1.apk!/assets/libnss3.so: Relocation to NULL @0x0014afdc for symbol "__cxa_begin_cleanup"

Flags: needinfo?(mshal)

Nick Alexander :nalexander [he/him]

Comment 11

•

10 years ago

(In reply to Michael Shal [:mshal] from comment #10)
> Is it possible to add more debug? It might be helpful if the "Couldn't get a
> handle to libxul!" message included the message from dlerror() (if the
> dlopen wrapper supports that). And the "Malformed or broken seekable
> zstream" makes 7 different checks - it would be nice to know which one in
> particular is failing.

I'm confident we could add additional debug logging.  I'd prefer not to do it myself right now, but if this languishes I can do it.

> Are these messages also real errors or just noise?
> 
> 1) 06:47:36     INFO -  10-25 06:47:33.156 W/GeckoLinker( 3770):
> /data/app/org.mozilla.fennec-1.apk!/assets/libnss3.so: unhandled flags #8
> not handled
> 
> 2) 06:47:36     INFO -  10-25 06:47:33.171 W/GeckoLinker( 3770):
> /data/app/org.mozilla.fennec-1.apk!/assets/libnss3.so: Relocation to NULL
> @0x0014afdc for symbol "__cxa_begin_cleanup"

I treat these two as noise; they've been present for me for at least 12 months.

Mike Hommey [:glandium]

Comment 12

•

10 years ago

(In reply to Michael Shal [:mshal] from comment #10)
> Is it possible to add more debug? It might be helpful if the "Couldn't get a
> handle to libxul!" message included the message from dlerror() (if the
> dlopen wrapper supports that). And the "Malformed or broken seekable
> zstream" makes 7 different checks - it would be nice to know which one in
> particular is failing.

It's actually not interesting to know that. That data comes straight from a read-only mmap of the apk, so the question is more why that data is corrupted than what specific bit doesn't match. That, is, we first need to know what is mapped (file, offset) at that address and check if that matches the location of libxul in the apk.

> Are these messages also real errors or just noise?
> 
> 1) 06:47:36     INFO -  10-25 06:47:33.156 W/GeckoLinker( 3770):
> /data/app/org.mozilla.fennec-1.apk!/assets/libnss3.so: unhandled flags #8
> not handled
> 
> 2) 06:47:36     INFO -  10-25 06:47:33.171 W/GeckoLinker( 3770):
> /data/app/org.mozilla.fennec-1.apk!/assets/libnss3.so: Relocation to NULL
> @0x0014afdc for symbol "__cxa_begin_cleanup"

Those are warnings. They don't matter, but hiding them could hide important information. That's just not relevant in the present case.

Mike Hommey [:glandium]

Comment 13

•

10 years ago

Also note that there is no evidence that the crashes for which this bug was opened and what's happening on infra are the same thing. We don't collect logcat in crashes do we?

Richard Newman [:rnewman]

Comment 14

•

10 years ago

The infrae log link indicates that infra does record logcats in process crashes:

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=508907&repo=mozilla-central

2152 19:33:14 WARNING - PROCESS-CRASH | java-exception | java.lang.Exception: Error loading gecko libraries at org.mozilla.gecko.mozglue.GeckoLoader.loadGeckoLibsNative(Native Method)
2159 19:33:15 WARNING - PROCESS-CRASH | Automation Error: Missing end of test marker (process crashed?)
2324 19:33:16 INFO - 10-20 19:33:11.398 E/GeckoLinker( 3848): Malformed or broken seekable zstream

Richard Newman [:rnewman]

Comment 15

•

10 years ago

But yes, we don't know if the cause of the failure to load libraries is the same. Certainly seems like a coincidence, though.

Mike Hommey [:glandium]

Comment 16

•

10 years ago

Discussion about the failure on infra should move to a separate bug then. Or a separate bug should be filed for the crashes from socorro.

James Willcox (:snorp) (jwillcox@mozilla.com) (he/him)

Comment 17

•

10 years ago

We've always had this crash, but are just now seeing it on crash-stats due to reporting changes. Google Play has shown this for a long time, but I think we had (clearly incorrect) assumptions that it was due to Play messing up an upgrade or something. We need to try to track this down. Do the failing builds from infra reproduce reliably? Meaning, is the APK messed up? Or as :glandium said, is this some problem with the mappings that occurs sporadically?

James Willcox (:snorp) (jwillcox@mozilla.com) (he/him)

Updated

•

10 years ago

Assignee: snorp → esawin

Mark Finkle (:mfinkle) (use needinfo?)

Updated

•

10 years ago

Flags: needinfo?(mark.finkle)

Randell Jesup [:jesup] (needinfo me)

Comment 18

•

10 years ago

This is happening a lot on my Nexus 10.  It's new in the last week or two.  Usually happens when switching back to nightly after selecting a link from g+ or elsewhere

Aaron Train [:aaronmt]

Reporter

Comment 19

•

10 years ago

I suggest getting that device into an android dev's hands to take a look

Randell Jesup [:jesup] (needinfo me)

Comment 20

•

10 years ago

(In reply to Aaron Train [:aaronmt] from comment #19)
> I suggest getting that device into an android dev's hands to take a look

Sorry, I'm remote and really can't lose a second tablet to Mozilla (I use it constantly).  ;-)

However, I can load up test code, adb, gdb, etc as needed, though I haven't done much myself on android recently (mostly b2g).

I haven't seen a crash (yet) since it took the latest nightly; I'd gotten ~5 over 4-5 days all with this signature:
bp-0fed9d0f-6d7b-4427-bdca-b7cc92141110 11/09/14 19:52
bp-fe6162d5-c16b-4793-a90c-3346f2141110 11/09/14 19:08
bp-d4bee6be-a20e-4586-86af-ce8022141109 11/08/14 21:22
bp-4cbe53a5-c352-41c0-aead-e6f0e2141107 11/06/14 20:54
bp-e86f0289-c45c-4db0-8dfb-d67022141106 11/05/14 19:16

Randell Jesup [:jesup] (needinfo me)

Comment 21

•

10 years ago

Note: all were 10/26 builds.  Due to @%@!@~!# Verizon and Netflix disagreeing over peering, updates of Nightly & Aurora are extremely hit-and-miss and often fail (downloads at 5-10K/s instead of my normal speed of 1-5MB/s)

Eugen Sawin [:esawin]

Assignee

Comment 22

•

10 years ago

According to crash reports, this isn't specific to some devices. I see a lot of the crashes reported on Nexus 5 and 7, but I fail to reproduce it on either.

Randell, can you still trigger it by opening links from apps like g+?

Eugen Sawin [:esawin]

Assignee

Comment 23

•

10 years ago

The crash has been declining rapidly on crash reports in the past week and it's not reproducing on Nexus 7 or 5 for me, which are among the top crashing devices. Randell, is it still reproducing for you on nightly?

Flags: needinfo?(rjesup)

Eugen Sawin [:esawin]

Assignee

Comment 24

•

10 years ago

Attached patch gecko-loader-cleanup — Details — Splinter Review

Just cleaning up some overlooked stuff from bug 855824. I can spin off a bug for that, if that's preferred.

Attachment #8523919 - Flags: review?(mh+mozilla)

Randell Jesup [:jesup] (needinfo me)

Comment 25

•

10 years ago

(In reply to Eugen Sawin [:esawin] from comment #23)
> The crash has been declining rapidly on crash reports in the past week and
> it's not reproducing on Nexus 7 or 5 for me, which are among the top
> crashing devices. Randell, is it still reproducing for you on nightly?

I don't think I got any crashes from it that weren't from one version (10/26? 23?) since auto-update of Nightly frequently fails here (mozilla's gateway to Verizon is fubar for months now - 3/4 times you get <15KB/s, often just totally failing in a large download)

Flags: needinfo?(rjesup)

Eugen Sawin [:esawin]

Assignee

Comment 26

•

10 years ago

Attached patch gecko-loader-error-logs — Details — Splinter Review

From my understanding, the issue can be caused by either a wrong offset (Zip::GetStream setting wrong file?) or a corrupted mapping (correct offset but wrong size? buffer issues?).

Independent from the present case, it doesn't hurt to provide more detailed error state logs when failing to initialize the zstream.
Zip::GetStream does seem to have good debug log coverage, we might just log the actual offset here for manual inspection.

Anything else that might be helpful?

Attachment #8523928 - Flags: feedback?(mh+mozilla)

Eugen Sawin [:esawin]

Assignee

Comment 27

•

10 years ago

According to crash reports [1], it hasn't been crashing past build no 20141028030204. Presumably, https://hg.mozilla.org/mozilla-central/rev/44c6d392bbc8 has fixed the issue.

[1] https://crash-stats.mozilla.com/report/list?product=FennecAndroid&signature=java.lang.Exception%3A+Error+loading+gecko+libraries+at+org.mozilla.gecko.mozglue.GeckoLoader.loadGeckoLibsNative%28Native+Method%29#tab-reports

Mike Hommey [:glandium]

Comment 28

•

10 years ago

Comment on attachment 8523919 [details] [diff] [review]
gecko-loader-cleanup

Review of attachment 8523919 [details] [diff] [review]:
-----------------------------------------------------------------

I think both should go in separate bugs.

::: mozglue/android/APKOpen.cpp
@@ -300,5 @@
>      return SUCCESS;
>  
>    chdir(getenv("GRE_HOME"));
>  
> -  RefPtr<Zip> zip = ZipCollection::GetZip(apkName);

Indeed, those are useless since bug 855824

::: mozglue/linker/Mappable.cpp
@@ +377,5 @@
>  MappableSeekableZStream::Create(const char *name, Zip *zip,
>                                  Zip::Stream *stream)
>  {
>    MOZ_ASSERT(stream->GetType() == Zip::Stream::STORE);
> +  UniquePtr<MappableSeekableZStream> mappable(new MappableSeekableZStream(zip));

nice cleanup

Attachment #8523919 - Flags: review?(mh+mozilla) → review+

Mike Hommey [:glandium]

Comment 29

•

10 years ago

Comment on attachment 8523928 [details] [diff] [review]
gecko-loader-error-logs

Review of attachment 8523928 [details] [diff] [review]:
-----------------------------------------------------------------

cf. comment 12, that's not really interesting.

Attachment #8523928 - Flags: feedback?(mh+mozilla) → feedback-

Eugen Sawin [:esawin]

Assignee

Comment 30

•

10 years ago

Fixed by https://hg.mozilla.org/mozilla-central/rev/44c6d392bbc8.

Status: NEW → RESOLVED

Closed: 10 years ago

Resolution: --- → FIXED

Aaron Train [:aaronmt]

Reporter

Updated

•

10 years ago

Keywords: regressionwindow-wanted

u279076

Comment 31

•

8 years ago

FYI, this has returned - filed bug 1283629.

[:philipp]

Updated

•

7 years ago

Updated

•

3 years ago

Product: Firefox for Android → Firefox for Android Graveyard

gecko-loader-cleanup 10 years ago Eugen Sawin [:esawin] 4.15 KB, patch	glandium : review+	Details \| Diff \| Splinter Review
gecko-loader-error-logs 10 years ago Eugen Sawin [:esawin] 1.21 KB, patch	glandium : feedback-	Details \| Diff \| Splinter Review