1089441 - Put bloattable.pl and bloatdiff.pl in the same directory

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nicholas Nethercote [inactive]]

We have tools/memory/bloattable.pl and tools/rb/bloatdiff.pl which are both used to process bloat logs, and so should live together.

One possibility is to move bloattable.pl into tools/rb/. Another is to create a new directory (tools/bloatview/, perhaps) and move them both in there. Which of these you prefer probably depends on whether you consider BloatView and the refcount balancer as part of a single thing, or distinct things; I lean towards the latter.

dbaron, do you have a preference?

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I don't think I have a strong opinion here, although I'd probably lean towards separate from tools/rb/.

(Sorry for the delay; it's taken a while to catch up from being away.)

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Move bloattable.pl and bloatdiff.pl into tools/bloatview/

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Update the refcount-balancer docs link

This is the new home for these docs.

Comment 4

[Nicholas Nethercote [inactive]]

(In reply to Nicholas Nethercote [:njn] from comment #2)
> Created attachment 8521837 [details] [diff] [review]
> Move bloattable.pl and bloatdiff.pl into tools/bloatview/

Note that because this patch only renames files, the "Review" and "Diff" links don't show anything.

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c8044919af6
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8a987028757

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2c8044919af6
https://hg.mozilla.org/mozilla-central/rev/a8a987028757

Comment 7

[Nicholas Nethercote [inactive]]

I updated https://developer.mozilla.org/en-US/docs/Mozilla/Performance/BloatView to reflect the new locations.