Closed Bug 1089441 Opened 5 years ago Closed 5 years ago

Put bloattable.pl and bloatdiff.pl in the same directory

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(2 files)

We have tools/memory/bloattable.pl and tools/rb/bloatdiff.pl which are both used to process bloat logs, and so should live together.

One possibility is to move bloattable.pl into tools/rb/. Another is to create a new directory (tools/bloatview/, perhaps) and move them both in there. Which of these you prefer probably depends on whether you consider BloatView and the refcount balancer as part of a single thing, or distinct things; I lean towards the latter.

dbaron, do you have a preference?
Flags: needinfo?(dbaron)
I don't think I have a strong opinion here, although I'd probably lean towards separate from tools/rb/.

(Sorry for the delay; it's taken a while to catch up from being away.)
Flags: needinfo?(dbaron)
This is the new home for these docs.
Attachment #8521838 - Flags: review?(dbaron)
(In reply to Nicholas Nethercote [:njn] from comment #2)
> Created attachment 8521837 [details] [diff] [review]
> Move bloattable.pl and bloatdiff.pl into tools/bloatview/

Note that because this patch only renames files, the "Review" and "Diff" links don't show anything.
Attachment #8521837 - Flags: review?(dbaron) → review+
Attachment #8521838 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/2c8044919af6
https://hg.mozilla.org/mozilla-central/rev/a8a987028757
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.