Closed Bug 1089638 Opened 10 years ago Closed 10 years ago

Crash with HTTP2 / PLDHashTable

Categories

(Core :: Networking: HTTP, defect)

Product:
Core
Component:
Networking: HTTP
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: robin, Unassigned)

References

Details

(Keywords: crash, reproducible, topcrash-mac)

Crash Data

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:36.0) Gecko/20100101 Firefox/36.0 Build ID: 20141027030204 Steps to reproduce: Unfortunately I don’t have a specific replication method, but it’s happened to me three times in the last hour or two of browsing. It wasn’t happening on Friday, but since I came into work this morning and grabbed the latest nightly Fx has crashed 3 times. Actual results: https://crash-stats.mozilla.com/report/index/36cca7a0-c93f-4da0-b596-4c0702141027 followed by: https://crash-stats.mozilla.com/report/index/cb87e0c7-48a8-4ebf-bed0-917382141027 and: https://crash-stats.mozilla.com/report/index/9ff8052d-3f31-4aa5-bb53-407a42141027 The second two have a different signature from the first, but they look (from an outsider’s viewpoint) like similar code. Expected results: No crashes.
Severity: normal → critical
Crash Signature: [@ PL_DHashTableOperate(PLDHashTable*, void const*, PLDHashOperator) | mozilla::net::Http2Session::CleanupStream(mozilla::net::Http2Stream*, tag_nsresult, mozilla::net::Http2Session::errorType) ]
One more of the first signature (mozilla::net::SpdySession31): https://crash-stats.mozilla.com/report/index/3d2b7525-5411-4cda-b716-4b9802141027
I got the same crash signature on Linux Mint: https://crash-stats.mozilla.com/report/index/bd451ccf-5add-4579-a907-36afc2141027 (already second time today)
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Mac OS X → All
I see these too. They seem to have started with today's mozilla-central nightly (2014-10-27-03-02-04-mozilla-central).
Keywords: crash, topcrash-mac
This is massively explosive. I can reproduce (in today's mozilla-central nightly) by closing a tab in which a YouTube video is running (using either Flash or HTML5).
Severity: critical → blocker
This appears to have been caused by bug 865314
Blocks: 865314
This should be fixed by the backout of the patch for bug 865314.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Crash Signature: [@ PL_DHashTableOperate(PLDHashTable*, void const*, PLDHashOperator) | mozilla::net::Http2Session::CleanupStream(mozilla::net::Http2Stream*, tag_nsresult, mozilla::net::Http2Session::errorType) ] → [@ PL_DHashTableOperate(PLDHashTable*, void const*, PLDHashOperator) | mozilla::net::Http2Session::CleanupStream(mozilla::net::Http2Stream*, tag_nsresult, mozilla::net::Http2Session::errorType) ] [@ PL_DHashTableOperate(PLDHashTable*, void const*, PLDHas…
(In reply to Steven Michaud from comment #9) > This should be fixed by the backout of the patch for bug 865314. I just hit this and I see that bug 865314 landed again last night https://crash-stats.mozilla.com/report/index/933e6c04-b4f5-4df3-bc13-62ad32141212 reopening
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I'm going to backout 865314 - m-i is closed, its pending on that.
865314 backs out what is almost certainly the root cause with comment 38 and cset https://hg.mozilla.org/integration/mozilla-inbound/rev/36d7afaaca18
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
This is preventing me from opening Twitter in the current Nightly. Hopefully the backout can be released to the update channel soon.
(Work around: set network.http.spdy.enabled.http2 to false.)
You need to log in before you can comment on or make changes to this bug.