Define new nginx configuration for change of url formats for loop-client

VERIFIED FIXED

Status

Hello (Loop)
Server
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: alexis)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [loop-server 0.13])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
For bug 1046114, I believe we are now ready to proceed - the standalone client has been updated for the new url formats.

We need to update the loop-client nginx format to cope with the new url formats:

* Calls are identified by tokens of the form https://hello.firefox.com/c/{token}
* Rooms are identified by tokens of the form https://hello.firefox.com/{token}

Ideally we should test this on the dev instance first, then roll it out via stage & prod with appropriate QA
So, this lives in Loop-Stage though, not Loop-Client?
The loop-client nginx format change lives in a config in Loop-Server?
(Reporter)

Comment 2

3 years ago
(In reply to James Bonacci [:jbonacci] from comment #1)
> So, this lives in Loop-Stage though, not Loop-Client?
> The loop-client nginx format change lives in a config in Loop-Server?

This is a change for the nginx instances that serve loop-client. These are handled by the server/ops teams. I believe the configs are in puppet somewhere.
(Assignee)

Comment 3

3 years ago
Created attachment 8515046 [details] [review]
nginx configuration change
Attachment #8515046 - Flags: review?(dwilson)
(Assignee)

Updated

3 years ago
Assignee: rhubscher → alexis+bugs
Whiteboard: [loop-server 0.13]
(Assignee)

Comment 4

3 years ago
I'm adding a NI for ops here since we would need to have this merged. Anything I can do to help that happening?
Flags: needinfo?(dwilson)
Flags: needinfo?(bwong)
Flags: needinfo?(bobm)
(Assignee)

Updated

3 years ago
Blocks: 1094754
Status: NEW → ASSIGNED
Going with multiple location blocks.  Closing ticket.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(bobm)
Resolution: --- → FIXED
Flags: needinfo?(bwong)
(Assignee)

Comment 6

3 years ago
I believe the change bob did is at https://github.com/mozilla-services/puppet-config/commit/d9cb6c43f8151733c9ffc9fe0d9b02c2f99b7ffe but isn't working properly as of now.

Bob, can you confirm you tried to deploy that and it wasn't working properly last time?
(Reporter)

Updated

3 years ago
Blocks: 1097989

Comment 7

3 years ago
This has been deployed after QA sign off so we'll assume what ever is deployed is correct. If it breaks we can reinvestigate.
(Reporter)

Comment 8

3 years ago
This has all been deployed now, and afaik is working correctly, hence verifying & clearing what appears to be an obsolete ni-request.
Status: RESOLVED → VERIFIED
Flags: needinfo?(dwilson)

Updated

3 years ago
Attachment #8515046 - Flags: review?(dwilson) → review+
You need to log in before you can comment on or make changes to this bug.