1089657 - Define new nginx configuration for change of url formats for loop-client

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[Mark Banner (:standard8)]

For bug 1046114, I believe we are now ready to proceed - the standalone client has been updated for the new url formats.

We need to update the loop-client nginx format to cope with the new url formats:

* Calls are identified by tokens of the form https://hello.firefox.com/c/{token}
* Rooms are identified by tokens of the form https://hello.firefox.com/{token}

Ideally we should test this on the dev instance first, then roll it out via stage & prod with appropriate QA

Comment 1

[James Bonacci [:jbonacci]]

So, this lives in Loop-Stage though, not Loop-Client?
The loop-client nginx format change lives in a config in Loop-Server?

Comment 2

[Mark Banner (:standard8)]

(In reply to James Bonacci [:jbonacci] from comment #1)
> So, this lives in Loop-Stage though, not Loop-Client?
> The loop-client nginx format change lives in a config in Loop-Server?

This is a change for the nginx instances that serve loop-client. These are handled by the server/ops teams. I believe the configs are in puppet somewhere.

Comment 3

[Alexis Metaireau (:alexis)]

Attachment: nginx configuration change

Comment 4

[Alexis Metaireau (:alexis)]

I'm adding a NI for ops here since we would need to have this merged. Anything I can do to help that happening?

Comment 5

[Bob Micheletto [:bobm]]

Going with multiple location blocks.  Closing ticket.

Comment 6

[Alexis Metaireau (:alexis)]

I believe the change bob did is at https://github.com/mozilla-services/puppet-config/commit/d9cb6c43f8151733c9ffc9fe0d9b02c2f99b7ffe but isn't working properly as of now.

Bob, can you confirm you tried to deploy that and it wasn't working properly last time?

Comment 7

[Dean Wilson (:deanw)]

This has been deployed after QA sign off so we'll assume what ever is deployed is correct. If it breaks we can reinvestigate.

Comment 8

[Mark Banner (:standard8)]

This has all been deployed now, and afaik is working correctly, hence verifying & clearing what appears to be an obsolete ni-request.