Fix NPE when setting pressed state on TabStripItemView

RESOLVED FIXED in Firefox 36

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 36
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The pressed state sometimes is triggered in a runnable internally and might run after the item view has been detached.
(Assignee)

Comment 1

4 years ago
Created attachment 8511998 [details] [diff] [review]
Avoid NPE on parent when tab strip item is pressed (r=mcomella)
(Assignee)

Updated

4 years ago
Attachment #8511998 - Flags: review?(michael.l.comella)
Comment on attachment 8511998 [details] [diff] [review]
Avoid NPE on parent when tab strip item is pressed (r=mcomella)

Review of attachment 8511998 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Lucas Rocha (:lucasr) from comment #0)
> The pressed state sometimes is triggered in a runnable internally and might
> run after the item view has been detached.

This seems like a pretty hard-to-find side-effect for users of TwoWayView - perhaps there is some way to fix this upstream?
Attachment #8511998 - Flags: review?(michael.l.comella) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Michael Comella (:mcomella) from comment #2)
> Comment on attachment 8511998 [details] [diff] [review]
> Avoid NPE on parent when tab strip item is pressed (r=mcomella)
> 
> Review of attachment 8511998 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> (In reply to Lucas Rocha (:lucasr) from comment #0)
> > The pressed state sometimes is triggered in a runnable internally and might
> > run after the item view has been detached.
> 
> This seems like a pretty hard-to-find side-effect for users of TwoWayView -
> perhaps there is some way to fix this upstream?

This bug is specific to our UI because we invalidate the parent when one of the child views is pressed (to update the dividers). Not something that can/should be fixed upstream.
https://hg.mozilla.org/mozilla-central/rev/01f896691284
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
You need to log in before you can comment on or make changes to this bug.