1089795 - [System] Layout problem with SHB in open file error dialog

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

Attachment: Screenshot of problem

STR
- Long press and download a file which can not be opened (currently HTML files or links fit this description).
- Try to open the content.

Comment 1

[Kevin Grandon :kgrandon]

[Blocking Requested - why for this release]: Broken functionality.

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8512216 [details] [review]
Github pull request

Mike or Eli - anyone got time for a review? Thanks!

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8512216 [details] [review]
Github pull request

Thanks for picking this up! We still need to only do this for '.software-button-enabled' case, as right now I think we apply this style even when SHB is disabled. Test looks great. Normally I'd just r+ this with that nit, but I want to play around with this a little before r+'ing on the device.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8512216 [details] [review]
Github pull request

Argh! Thanks for catching that.. again ;-)

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8512216 [details] [review]
Github pull request

One small but important comment on github. r=me

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8512216 [details] [review]
Github pull request

Mike - heh, good thing I looked at your nit. Taking a look again, it appears that #downloadConfirmUI is a sibling (not child) of #screen. I'm not sure why this is, but to fix it for now, the easiest thing to do is to update the selector to use an adjacent sibling selector. Just wanted to re-flag you for awareness.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8512216 [details] [review]
Github pull request

Wow, good catch! We have way too many dialog scenarios in the system app for my sanity. Thanks for the fix!

Comment 9

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/a2c5cfa4347ad25868650ebfeb4f3dca17147b72

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8512216 [details] [review]
Github pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Missed case during feature implementation.
[User impact] if declined: Poor UX when using software home button.
[Testing completed]: Manual and integration test.
[Risk to taking this patch] (and alternatives if risky): Low risk, only new styles and scoped to this specific dialog.
[String changes made]: None.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/84b8eb5d9a918e590904b771f6f22f9d2ed94834

Comment 12

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1 and 2.2.

Result: The dialog fits properly in the screen with SHB enabled.

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141031001201
Gaia: f89c7b12c36572262c9ea76058694a139b1a8634
Gecko: 50d48f8a04c7
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141031061804
Gaia: a07994714f0552f89801d6097982308d8b0a1ee1
Gecko: 6bd2071b373f
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0