1090018 - Unexpected space shows on the bottom of keyboard when passcode and software home button are enabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

STR:
1. enable simpin and software home button and passcode.
2. restart device and unlock screen

Actual: transparent space shows on the bottom of number keyboard
Expect: keyboard should be aligned at the bottom

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Greg, 
do you have any idea for it?

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Although I feel to concat the ':not' to let become longer and longer may be not a good idea, but since it's the existing logic so I follow it to patch this bug.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8512434 [details] [review]
Patch

Please mark the dependency (regression of lockscreenInputWindow)

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

The patch only encountered one ringtone intermittent test failure:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=632cfcc3c82e

Which had failed at other patches like this:

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=7142abc41b09

So I would land this patch.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

https://github.com/mozilla-b2g/gaia/commit/d78e9dc7bac48c13dfa8e4fedefd72a96db51d9e