1090041 - [Bluetooth] No onpairedstatuschanged event coming after paired/unpaired a device.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail], [e-mail]]

Steps to Reproduce:

0. No paired device in the phone.
1. Launch settings app to pair a device in Bluetooth panel.
2. Checking description of Bluetooth menu in settings root panel.

Expected:
The first paired device name should be listed in the description of Bluetooth menu.

Actual:
Still display 'No devices paired'. (Sometimes, it displays the name of paired device.)

Steps to Reproduce:
Base on STR 2, and the first paired device name displayed normally.

3. Go into Bluetooth panel.
4. Unpair a paired devices in the list.

Expected:
Should display 'No devices paired' in the description of Bluetooth menu.

Actual:
Still display the unpaired device name which we just unpaired it.


Build:
Gaia-Rev        6a7fb482a03c5083ef79b41e7b0dfab27527cd04
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/a255a234946e
Build-ID        20141027175024
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141027.211305
FW-Date         Mon Oct 27 21:13:15 EDT 2014
Bootloader      L1TC10011800

Comment 1

[[e-mail], [e-mail]]

I try to add some console log for tracking `onpairedstatuschanged` event. I don't see the event coming while paired/unpaired a device.

https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/modules/bluetooth.js#L152-L157

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

This is a regression form 2.1 so nominating this 2.2?

Comment 4

[Duane Dixon [:ddixon]]

Unable to provide a regression window for this issue.  The issue is blocked from being reproduced. 

A bluetooth connection between devices cannot be made.

I am seeing the following results in earlier builds (9/4 - 10/25)
-Device 'B' will display a confirmation number while Device 'A' will only trigger a notification which does not function when selected. 
-This blocks the user from pairing devices via bluetooth.

Also, the repro rate is intermittent (less than 50%). 

Overall, 30+ builds were tested while attempting to find a regression window here.

Comment 5

[howie [:howie]]

Triage: regression, blocking.

Comment 6

[Ben Tian (inactive)]

On today's build I see settings app receive 'onpairedstatuschanged' event but description is still incorrect. Investigating settings app for cause.

(In reply to Ian Liu [:ianliu] from comment #1)
> I try to add some console log for tracking `onpairedstatuschanged` event. I
> don't see the event coming while paired/unpaired a device.
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/modules/
> bluetooth.js#L152-L157

Comment 7

[Ben Tian (inactive)]

Attachment: pair-gaia-log.patch

The cause is that onpairedstatuschanged event handler is not re-attached to watch paired status change [1] after BT is turned on again. Attach gaia patch to show debugging logs.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/modules/bluetooth/bluetooth_v1.js#L152

Comment 8

[Ben Tian (inactive)]

Ian, please help check this bug in gaia. Thanks.

Comment 9

[[e-mail], [e-mail]]

Attachment: pull request 26759

Per offline discussion with Arthur and Ben, the new adapter won't hold callback functions which is register before. So that the callback function won't be executed after we turned Bluetooth on/off. We have to register the callback function from old adapter to the new one.

Arthur, could you please help to review my pull request? Thanks.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8536352 [details] [review]
pull request 26759

r=me, thanks!

Comment 11

[[e-mail], [e-mail]]

Thanks for Arthur's reviewing effort. Since the patch is landed, we can close the issue now.

Gaia/master:  f1316844d0dc0da139619041cf62c6498821a9ea

Comment 12

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2.

Result: The name of paired device or "No devices paired" is displayed correctly on the Settings menu screen.

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141218040201
Gaia: 58734e8a48157f99d5b733412b600c2e04c954fe
Gecko: 5c7a6294b82a
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0