Closed
Bug 1090211
Opened 10 years ago
Closed 10 years ago
Calculate the bounds of circles and ellipses using Math when we have a rectilinear transform
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
5.79 KB,
patch
|
longsonr
:
review+
jwatt
:
checkin+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8512667 -
Flags: review?(longsonr)
Updated•10 years ago
|
Attachment #8512667 -
Flags: review?(longsonr) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8512667 [details] [diff] [review] patch https://hg.mozilla.org/integration/mozilla-inbound/rev/b51051e5ac2e
Attachment #8512667 -
Flags: checkin+
Assignee | ||
Comment 3•10 years ago
|
||
This provided a big perf improvement described in bug 554004 comment 28.
Comment 4•10 years ago
|
||
Lines, polygons and polylines could be done too by finding the min/max x/y values couldn't they?
Assignee | ||
Comment 5•10 years ago
|
||
To have tight bounds for polygons and polylines would be trickier with things like stroke-miterlimit, even without a transform. Combine that with a transform and it's a bit of work not to end up with bounds-of-transformed-bounds. I think we'd need to calculate all the vertices of the stroke _outline_, transform those, then find the min/max values.
Comment 6•10 years ago
|
||
Could restrict it to stuff without strokes to begin with.
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b51051e5ac2e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•