Closed Bug 1090211 Opened 6 years ago Closed 6 years ago

Calculate the bounds of circles and ellipses using Math when we have a rectilinear transform

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 2 open bugs)

Details

(Keywords: perf)

Attachments

(1 file)

No description provided.
Keywords: perf
Attached patch patchSplinter Review
Attachment #8512667 - Flags: review?(longsonr)
Attachment #8512667 - Flags: review?(longsonr) → review+
Blocks: 949661
Blocks: 554004
This provided a big perf improvement described in bug 554004 comment 28.
Lines, polygons and polylines could be done too by finding the min/max x/y values couldn't they?
To have tight bounds for polygons and polylines would be trickier with things like stroke-miterlimit, even without a transform. Combine that with a transform and it's a bit of work not to end up with bounds-of-transformed-bounds. I think we'd need to calculate all the vertices of the stroke _outline_, transform those, then find the min/max values.
Could restrict it to stuff without strokes to begin with.
https://hg.mozilla.org/mozilla-central/rev/b51051e5ac2e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.