1090305 - [10.10] Remove Noise Texture from Toolbar(s)

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Stephen Horlander [:shorlander]]

Attachment: Noise Texture

Yosemite does not have a toolbar noise texture.

Comment 1

[Alexander Ploner]

Attachment: bug-1090305-v1.patch

This patch removes the noise from all toolbars for OS X Yosemite.

The noise inside the tabs should be addressed in bug 1101811 as this bug already requires new tab images. Also the noise inside the tab images seems to be much lighter. I think this patch can be checked-in without waiting for the tab noise to be removed.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8642164 [details] [diff] [review]
bug-1090305-v1.patch

> #navigator-toolbox > toolbar:not(#TabsToolbar):not(#nav-bar):not(:-moz-lwtheme) {
>   -moz-appearance: none;
>   background: url(chrome://browser/skin/Toolbar-background-noise.png) hsl(0,0%,83%);
> }
> 
>+/* remove noise texture on Yosemite */
>+@media (-moz-mac-yosemite-theme) {
>+  #navigator-toolbox > toolbar:not(#TabsToolbar):not(#nav-bar):not(:-moz-lwtheme) {
>+    background: hsl(0,0%,83%);
>+  }
>+}

nit: you can just use background-image: none; here instead of repeating the color.

Comment 3

[Alexander Ploner]

Attachment: bug-1090305-v2.patch

(In reply to Dão Gottwald [:dao] from comment #2)
> nit: you can just use background-image: none; here instead of repeating the
> color.

I first tried it that way but for some reason it didn't work in my local build. Probably I did anything wrong. I tried it again an this time it worked.

I updated the patch as this is indeed the better solution, even if it's only a minimal difference ;).
If someone wants to change the color it makes a difference ;).

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3ae9930347ad

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ae9930347ad

Comment 6

[Petruta Horea [:phorea], PTO until 8/22/25]

Verified as fixed during Firefox 42 beta 7 testday (https://public.etherpad-mozilla.org/p/testday-20151016).