Closed Bug 1090305 Opened 5 years ago Closed 4 years ago

[10.10] Remove Noise Texture from Toolbar(s)

Categories

(Firefox :: Theme, defect)

x86
macOS
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 42
Tracking Status
firefox42 --- verified

People

(Reporter: shorlander, Assigned: alex)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Attached image Noise Texture
Yosemite does not have a toolbar noise texture.
Attached patch bug-1090305-v1.patch (obsolete) — Splinter Review
This patch removes the noise from all toolbars for OS X Yosemite.

The noise inside the tabs should be addressed in bug 1101811 as this bug already requires new tab images. Also the noise inside the tab images seems to be much lighter. I think this patch can be checked-in without waiting for the tab noise to be removed.
Assignee: nobody → alex
Status: NEW → ASSIGNED
Attachment #8642164 - Flags: review?(dao)
Comment on attachment 8642164 [details] [diff] [review]
bug-1090305-v1.patch

> #navigator-toolbox > toolbar:not(#TabsToolbar):not(#nav-bar):not(:-moz-lwtheme) {
>   -moz-appearance: none;
>   background: url(chrome://browser/skin/Toolbar-background-noise.png) hsl(0,0%,83%);
> }
> 
>+/* remove noise texture on Yosemite */
>+@media (-moz-mac-yosemite-theme) {
>+  #navigator-toolbox > toolbar:not(#TabsToolbar):not(#nav-bar):not(:-moz-lwtheme) {
>+    background: hsl(0,0%,83%);
>+  }
>+}

nit: you can just use background-image: none; here instead of repeating the color.
Attachment #8642164 - Flags: review?(dao) → review+
(In reply to Dão Gottwald [:dao] from comment #2)
> nit: you can just use background-image: none; here instead of repeating the
> color.

I first tried it that way but for some reason it didn't work in my local build. Probably I did anything wrong. I tried it again an this time it worked.

I updated the patch as this is indeed the better solution, even if it's only a minimal difference ;).
If someone wants to change the color it makes a difference ;).
Attachment #8642164 - Attachment is obsolete: true
Attachment #8643896 - Flags: review?(dao)
Attachment #8643896 - Flags: review?(dao) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3ae9930347ad
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Verified as fixed during Firefox 42 beta 7 testday (https://public.etherpad-mozilla.org/p/testday-20151016).
Status: RESOLVED → VERIFIED
QA Whiteboard: [testday-20151016]
You need to log in before you can comment on or make changes to this bug.