reftest 1082844-1 fails on Android and B2G-emulator due to misplaced content in vertical-rl block

RESOLVED FIXED in mozilla37

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

(Blocks 1 bug)

unspecified
mozilla37
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
According to https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e6519895b781, it looks like this reftest is going to go orange when we enable vertical support. :(

Checking the reftest-analyzer view, this looks like a real bug, where the content of the test <div> is misplaced upwards and slightly right in the testcase, while the reference renders correctly. So this needs debugging and fixing before we can ship vertical support on mobile.

Offhand, I'm not sure why this should affect mobile, while working correctly on desktop platforms.
(Assignee)

Updated

5 years ago
(Assignee)

Comment 1

4 years ago
This appears to be triggered by incorrect (vertical) glyph advances when using the freetype backend (which also affects the GDI backend, actually, and results in terribly-spaced text). The platform-specific GetGlyphWidth method is returns the horizontal glyph width, which should never be used by GetGlyphVAdvance. (I think this code is a remnant of an early version of the vertical-text support, where I was going to instantiate separate gfxFont instances for vertical vs horizontal use.)
(Assignee)

Comment 2

4 years ago
With this removed, the 1082844-1 test no longer fails on mobile platforms.
Attachment #8541846 - Flags: review?(smontagu)
(Assignee)

Updated

4 years ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8541846 [details] [diff] [review]
gfxHarfBuzzShaper::GetGlyphVAdvance should never use the backend-specific GetGlyphWidth method, which is for horizontal width only

Review of attachment 8541846 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable, though I'm not exactly familiar with this code.
Attachment #8541846 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/67960aabce3a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.