Bug 1099032 (enable-writing-mode-dev)

enable CSS writing-mode support in developer channels

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla39
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39+ fixed, relnote-firefox 39+)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

4 years ago
This is intended to be the bug where we'll toggle the layout.css.vertical-text.enabled pref to true, so that vertical writing mode can actually be used.

This will not be the end of work on vertical writing mode, as the initial release will not support vertical mode for all elements or CSS constructs; e.g. tables, grid, form controls, etc., etc., may be horizontal-only at first.

Add "depends on" references here for the vertical writing-mode bugs that are essential to fix before we can usefully enable the feature. Additional aspects of vertical support that we want to implement eventually, but that need not block the initial release, should be marked as blocking (directly or indirectly) the main writing-mode bug instead of this one.
(Assignee)

Comment 1

4 years ago
Created attachment 8522865 [details] [diff] [review]
Enable CSS writing-mode support.

Here's the patch to enable writing-mode; we're not ready to consider landing this yet, though.
(Assignee)

Updated

4 years ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Depends on: 1076657, 1077515
(Assignee)

Updated

4 years ago
Depends on: 1102406
(Assignee)

Updated

4 years ago
Depends on: 1105268
(Assignee)

Updated

4 years ago
Depends on: 1107960
(Assignee)

Updated

4 years ago
Depends on: 1108067
(Assignee)

Updated

4 years ago
Depends on: 1108071
(Assignee)

Updated

4 years ago
Depends on: 1108923
(Assignee)

Updated

4 years ago
Depends on: 1111517
(Assignee)

Updated

4 years ago
Depends on: 1111944
(Assignee)

Updated

4 years ago
Depends on: 1083134
(Assignee)

Updated

4 years ago
Depends on: 1115916
(Assignee)

Updated

4 years ago
Depends on: 1118943
(Assignee)

Updated

4 years ago
Depends on: 1119475
(Assignee)

Updated

4 years ago
Depends on: 1119770
(Assignee)

Updated

4 years ago
Depends on: 1120101
(Assignee)

Updated

4 years ago
Depends on: 1120102
Alias: enable-writing-mode
(Assignee)

Updated

4 years ago
Depends on: 1124661
(Assignee)

Updated

4 years ago
Depends on: 1126420
Depends on: 1114329
Keywords: dev-doc-needed
Depends on: 1130907
(Assignee)

Updated

4 years ago
Depends on: 1082017
(Assignee)

Updated

4 years ago
Depends on: 1131994
(Assignee)

Comment 2

4 years ago
Note that the patch in bug 1082017 will need to land together with this bug, otherwise we'll get mochitest failures. (But it can't land earlier, because it depends on writing-mode being supported.)
(Assignee)

Comment 3

4 years ago
(In reply to Jonathan Kew (:jfkthame) from comment #2)
> Note that the patch in bug 1082017 will need to land together with this bug,
> otherwise we'll get mochitest failures. (But it can't land earlier, because
> it depends on writing-mode being supported.)

This is no longer an issue, as that patch was modified so as to land safely, independently of the pref change here.
(Assignee)

Comment 4

4 years ago
Created attachment 8566478 [details] [diff] [review]
Enable CSS writing-mode support by default for nightly/aurora builds

Time to consider flipping the pref on non-release channels (nightly/dev), so that we can begin to get wider testing of what's been implemented so far? This will also mean that the writing-mode tests start running on mozilla-central, which IMO is highly desirable.
Attachment #8566478 - Flags: review?(smontagu)
(Assignee)

Updated

4 years ago
Attachment #8522865 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Depends on: 1134598
(Assignee)

Comment 5

4 years ago
Created attachment 8566488 [details] [diff] [review]
Enable CSS writing-mode support by default for nightly/aurora builds

If we do bug 1134598 separately, then all that's left here is the pref change.
Attachment #8566488 - Flags: review?(smontagu)
(Assignee)

Updated

4 years ago
Attachment #8566478 - Attachment is obsolete: true
Attachment #8566478 - Flags: review?(smontagu)
(Assignee)

Updated

4 years ago
Depends on: 1134849
(Assignee)

Comment 6

4 years ago
As per discussion with jet/dbaron/heycam today, the proposal is to do this *after* next week's uplift.
... #ifndef RELEASE_BUILD, that is.  With notification to firefox-dev and dev-gaia that it's enabled for nightly/aurora only, so they shouldn't depend on it yet.
Attachment #8566488 - Flags: review?(smontagu) → review+
(Assignee)

Updated

4 years ago
Alias: enable-writing-mode → enable-writing-mode-dev
Summary: enable CSS writing-mode support → enable CSS writing-mode support in developer channels
(Assignee)

Updated

4 years ago
Blocks: 1138384
(Assignee)

Updated

4 years ago
Depends on: 1139646
(Assignee)

Updated

4 years ago
Depends on: 1136557
Tracking for Firefox 39.
tracking-firefox39: --- → +
No longer depends on: 1130937
No longer depends on: 1130935
No longer depends on: 1118103
No longer depends on: 1122253
No longer depends on: 1130907
https://hg.mozilla.org/mozilla-central/rev/f0b9e9a81916
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Release Note Request (optional, but appreciated)
[Why is this notable]: Cool new feature on dev channels. 
[Suggested wording]: Vertical text mode enabled by default on Developer Edition
[Links (documentation, blog post, etc)]:  https://developer.mozilla.org/en-US/docs/Web/CSS/writing-mode
relnote-firefox: --- → 39+
Jonathan, is this likely to stay enabled or be turned off when 39 moves to beta? Would exploratory testing help or does this need the automated tests for us to feel that it's ready for release? Thanks.
Flags: needinfo?(jfkthame)
(Assignee)

Comment 15

3 years ago
For 39, and probably another cycle or two, it'll stay disabled on beta/release channels. (The pref is subject to #ifdef RELEASE_BUILD in all.js.)

Bug 1138384 will track enabling the feature on release. (It's not primarily a question of testing, but of feature completeness: there are some substantial parts of CSS layout that do not yet handle vertical mode, such as tables.)
Flags: needinfo?(jfkthame)
You need to log in before you can comment on or make changes to this bug.