apps/communications/contacts/test/marionette/contacts_shortcuts_test.js permared on v2.0

RESOLVED FIXED in Firefox OS v2.0

Status

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: etienne, Assigned: arcturus)

Tracking

unspecified
2.1 S9 (21Nov)
x86
Mac OS X

Firefox Tracking Flags

(b2g-v2.0 fixed, b2g-v2.0M fixed, b2g-v2.1 unaffected, b2g-v2.2 unaffected)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
1) Contacts shortcuts > touch touch on shortcuts press/release on scrollbar should show/hide shortcut:
     
  AssertionError: 1 == 0
      at Context.<anonymous> (/Users/segonzac/Mozilla/gaia/apps/communications/contacts/test/marionette/contacts_shortcuts_test.js:40:14)
      at callFn (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runnable.js:223:21)
      at Test.Runnable.run (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runnable.js:216:7)
      at Runner.runTest (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:373:10)
      at /Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:451:12
      at next (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:298:14)
      at /Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:308:7
      at next (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:246:23)
      at Object._onImmediate (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:275:5)
      at processImmediate [as _immediateCallback] (timers.js:345:15)
(Reporter)

Updated

4 years ago
Assignee: nobody → francisco
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S8 (7Nov)
Status: NEW → ASSIGNED
Created attachment 8512910 [details] [review]
Pointer to PR 25586 against v2.0

Jose can you review?
Attachment #8512910 - Flags: review?(jmcf)

Comment 2

4 years ago
Comment on attachment 8512910 [details] [review]
Pointer to PR 25586 against v2.0

thanks Francisco
Attachment #8512910 - Flags: review?(jmcf) → review+
Target Milestone: 2.1 S8 (7Nov) → 2.1 S9 (21Nov)
Hi Ryan,

could you merge this into 2.0?
Flags: needinfo?(ryanvm)
v2.0: https://github.com/mozilla-b2g/gaia/commit/ab83632c92f9fc571b11d8468b6901cc4ed905c0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → unaffected
status-b2g-v2.2: --- → unaffected
Flags: needinfo?(ryanvm)
Resolution: --- → FIXED
status-b2g-v2.0M: --- → fixed

Updated

3 years ago
Blocks: 1054172
You need to log in before you can comment on or make changes to this bug.