1090408 - apps/communications/contacts/test/marionette/contacts_shortcuts_test.js permared on v2.0

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Etienne Segonzac (:etienne)]

1) Contacts shortcuts > touch touch on shortcuts press/release on scrollbar should show/hide shortcut:
     
  AssertionError: 1 == 0
      at Context.<anonymous> (/Users/segonzac/Mozilla/gaia/apps/communications/contacts/test/marionette/contacts_shortcuts_test.js:40:14)
      at callFn (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runnable.js:223:21)
      at Test.Runnable.run (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runnable.js:216:7)
      at Runner.runTest (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:373:10)
      at /Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:451:12
      at next (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:298:14)
      at /Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:308:7
      at next (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:246:23)
      at Object._onImmediate (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:275:5)
      at processImmediate [as _immediateCallback] (timers.js:345:15)

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 25586 against v2.0

Jose can you review?

Comment 2

[Jose Manuel Cantera]

Comment on attachment 8512910 [details] [review]
Pointer to PR 25586 against v2.0

thanks Francisco

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hi Ryan,

could you merge this into 2.0?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/ab83632c92f9fc571b11d8468b6901cc4ed905c0