Closed Bug 1090408 Opened 9 years ago Closed 9 years ago

apps/communications/contacts/test/marionette/contacts_shortcuts_test.js permared on v2.0

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed, b2g-v2.0M fixed, b2g-v2.1 unaffected, b2g-v2.2 unaffected)

Status:
RESOLVED FIXED
Milestone:
2.1 S9 (21Nov)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.0M --- fixed
b2g-v2.1 --- unaffected
b2g-v2.2 --- unaffected

People

(Reporter: etienne, Assigned: arcturus)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

Pointer to PR 25586 against v2.0
46 bytes, text/x-github-pull-request
jmcf
: review+
Details | Review 
1) Contacts shortcuts > touch touch on shortcuts press/release on scrollbar should show/hide shortcut:
     
  AssertionError: 1 == 0
      at Context.<anonymous> (/Users/segonzac/Mozilla/gaia/apps/communications/contacts/test/marionette/contacts_shortcuts_test.js:40:14)
      at callFn (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runnable.js:223:21)
      at Test.Runnable.run (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runnable.js:216:7)
      at Runner.runTest (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:373:10)
      at /Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:451:12
      at next (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:298:14)
      at /Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:308:7
      at next (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:246:23)
      at Object._onImmediate (/Users/segonzac/Mozilla/gaia/node_modules/mocha/lib/runner.js:275:5)
      at processImmediate [as _immediateCallback] (timers.js:345:15)
Assignee: nobody → francisco
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S8 (7Nov)
Status: NEW → ASSIGNED
Jose can you review?
Attachment #8512910 - Flags: review?(jmcf)
Comment on attachment 8512910 [details] [review]
Pointer to PR 25586 against v2.0

thanks Francisco
Attachment #8512910 - Flags: review?(jmcf) → review+
Target Milestone: 2.1 S8 (7Nov) → 2.1 S9 (21Nov)
Hi Ryan,

could you merge this into 2.0?
Flags: needinfo?(ryanvm)
v2.0: https://github.com/mozilla-b2g/gaia/commit/ab83632c92f9fc571b11d8468b6901cc4ed905c0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → unaffected
status-b2g-v2.2: --- → unaffected
Flags: needinfo?(ryanvm)
Resolution: --- → FIXED
Blocks: Woodduck
You need to log in before you can comment on or make changes to this bug.