Closed Bug 1090456 Opened 9 years ago Closed 9 years ago

Tabview can leak if it is open when a tab is restored in e10s mode

Categories

(Firefox Graveyard :: Panorama, defect)

Product:
Firefox Graveyard
Component:
Panorama
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(e10sm3+)

Status:
RESOLVED FIXED
Milestone:
Firefox 36
Tracking Flags:
Tracking Status
e10s m3+ ---

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
3.70 KB, patch
mconley
: review+
Details | Diff | Splinter Review 
It uses a DOM event listener to wait for a load event that never comes in e10s mode so the listener leaks.
Flags: qe-verify-
Flags: firefox-backlog+
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #8512935 -
        Flags: review?(mconley)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #8512935 -
        Attachment is obsolete: true

        Attachment #8512935 -
        Flags: review?(mconley)

        Attachment #8512938 -
        Flags: review?(mconley)

    
    

    
  
Comment on attachment 8512938 [details] [diff] [review]
patch

Review of attachment 8512938 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine - but I'm wondering if this particular pattern is more common than we think. A quick dxr for addEventListener("load", has quite a few non-mochitest results... we might want to audit those at some point to ensure e10s doesn't cause similar leaks elsewhere.

        Attachment #8512938 -
        Flags: review?(mconley) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5a9f63201e5c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.