1090456 - Tabview can leak if it is open when a tab is restored in e10s mode

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Dave Townsend [:mossop]]

It uses a DOM event listener to wait for a load event that never comes in e10s mode so the listener leaks.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8512938 [details] [diff] [review]
patch

Review of attachment 8512938 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine - but I'm wondering if this particular pattern is more common than we think. A quick dxr for addEventListener("load", has quite a few non-mochitest results... we might want to audit those at some point to ensure e10s doesn't cause similar leaks elsewhere.

Comment 4

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/fx-team/rev/5a9f63201e5c

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5a9f63201e5c