1090710 - [tracking] migrate from yui to jquery

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[:glob ✱]

tracking bug for migrating from yui2 to jquery + jquery-ui + datatables.net.

Comment 1

[Kapil Bakshi[geekspark]]

I want to start working on YUI to jquery migration . May I get the instructions please ? Thanks.

Comment 2

[Andre Klapper]

(In reply to Kapil Bakshi[geekspark] from comment #1)
> I want to start working on YUI to jquery migration . May I get the
> instructions please ? Thanks.

That is great, thanks for your interest! 
What kind of "instructions" do you expect?

Comment 3

[Kapil Bakshi[geekspark]]

On which files should I start working on . I think I would have to start coding on the Javascript files inside the directory  bugzilla/js,right. Any other files I need to take care of..? Thanks.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Most of the javascript will be in the js/ directory -- inline javascript does exist but we can get to that last.

I think a good starting point would be https://github.com/bugzilla/bugzilla/blob/master/js/TUI.js
and https://github.com/bugzilla/bugzilla/blob/master/js/util.js,
which are collections of small utility functions. jquery's conciseness may even make them unnecessary.

Feel free to drop by #bugzilla on irc.mozilla.org if you have other questions and need a quick-ish response.

Comment 5

[Kapil Bakshi[geekspark]]

Thanks David. I am excited to start working on this. Can this project become a part of GSOC 2015 ?

Comment 6

[Kapil Bakshi[geekspark]]

Dylan Sir, the files you mentioned in your comment consist of functions only. I would like to know where are they being called . Also the code can be easily migrated to jquery using selectors and filters. Shall I only write the corresponding jquery code of these  two files now . Is there anything else I should consider .?

Thanks :)

Comment 7

[Kapil Bakshi[geekspark]]

and regarding cookie implementation should I use the carhart jquery plugin ?

Comment 8

[:glob ✱]

(In reply to Kapil Bakshi[geekspark] from comment #6)
> Dylan Sir, the files you mentioned in your comment consist of functions
> only. I would like to know where are they being called . Also the code can
> be easily migrated to jquery using selectors and filters.

it's best to perform a straight migration of the existing instead of refactoring at the same time to use jquery selectors and filters.  this makes the code much easier to review and test.

refactoring to make better use of jquery is an excellent idea, but something that should be done later.

> and regarding cookie implementation should I use the carhart jquery plugin ?

yes; that's the one we ship with bugzilla.


i'll file a new bug for the TUI.js and util.js work and assign it to you.

Comment 9

[Kohei Yoshino [:kohei]]

I have closed some dependencies as WONTFIX as we are going to remove jQuery as well, just like GitHub. We are more fortunate because we have already dropped the IE support. Let’s say goodbye to YUI *and* jQuery!

https://githubengineering.com/removing-jquery-from-github-frontend/