1159589 - migrate autocomplete from yui to jquery

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[:glob ✱]

we need to migrate autocomplete from yui to jquery.

Comment 1

[:glob ✱]

Attachment: 1159589_1.patch

- replace yui with jquery in js/fields.js
- implement user autocompletion
- implement keyword and bug tag autocompletion
- stop using include yui autocomplete resources in a lot of templates

note: comment tagging still uses yui's autocompletion, that's a lot more work which i've shifted to bug 1159596

Comment 2

[:glob ✱]

Attachment: 1159589_2.patch

i realised it would be better to move comment-tagging's autocompletion here, and deal with the rest of the jquery migration in bug 1159596.

- replace yui with jquery in js/fields.js
- implement user autocompletion
- implement keyword and bug tag autocompletion
- implement comment tagging autocompletion
- remove support for yui autocomplete from global header
- stop using include yui autocomplete resources in all of templates

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8599159 [details] [diff] [review]
1159589_2.patch

Review of attachment 8599159 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like this has bit-rotted?

Comment 4

[Dylan Hardison [:dylan] (he/him)]

No, I'm just an idiot that did "bz new 1159589" without saying that this was on *upstream* and not BMO.

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8599159 [details] [diff] [review]
1159589_2.patch

Review of attachment 8599159 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan but fix the trailing comma on commit

::: js/comment-tagging.js
@@ +38,5 @@
> +            serviceUrl: function(query) {
> +                return 'rest/bug/comment/tags/' + encodeURIComponent(query);
> +            },
> +            params: {
> +                Bugzilla_api_token: BUGZILLA.api_token,

nit: trailing comma

Comment 6

[:glob ✱]

To ssh://[e-mail]/bugzilla/bugzilla.git
   7a75256..33a4bd4  master -> master