1090817 - [marionette-file-manager] Could add all files in a folder

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Evan Tseng [:evanxd]]

Could add all files in a folder via the add method[1].
See the use case in [2].


[1] https://github.com/mozilla-b2g/marionette-file-manager/blob/master/lib/desktop_client_file_manager.js#L17-L24
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1080090#c31

Comment 1

[Evan Tseng [:evanxd]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/marionette-file-manager/pull/5

Comment 2

[Evan Tseng [:evanxd]]

Comment on attachment 8514183 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/marionette-file-manager/pull/5

Hi James,

Could you have time to review the patch?
The Travis CI job of mozilla-b2g/marioneete-file-manager is not working. Then I just trigger the job in my repository. See the result here[1].

For travis not working issue, maybe we should check the our settings in travis first. It might be not opened to run CI job.

Thanks.

[1] https://travis-ci.org/evanxd/marionette-file-manager/builds/39474106

Comment 3

[James Lal [:lightsofapollo]]

Comment on attachment 8514183 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/marionette-file-manager/pull/5

Gave it a skim looks reasonable... r+

Comment 4

[James Lal [:lightsofapollo]]

Also turned on travis in main repo thanks Evan!

Comment 5

[Evan Tseng [:evanxd]]

James,thanks for the review.

Comment 6

[Evan Tseng [:evanxd]]

Hi Punam,

We already added the feature of adding all files in a directory, you could start to write the tests. This[1] is how to use it.

[1] https://github.com/mozilla-b2g/marionette-file-manager#add-files-into-the-specified-directory

Comment 7

[Punam Dahiya [:pdahiya]]

Woo Hoo! Thanks Evan, I have created bug 1092233 to use updated marionette-file-manager API to write integration tests to scan and load all test images in gallery app.

Comment 8

[Evan Tseng [:evanxd]]

BTW, Puman, just a reminder, you also need to update gaia-node-modules[1] to use the updated marionette-file-manager.

[1] https://github.com/mozilla-b2g/gaia-node-modules/