Closed Bug 1092233 Opened 10 years ago Closed 7 years ago

[Gallery] - Marionette JS Integration test to scan and load test images

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: pdahiya, Assigned: pdahiya)

Details

Attachments

(3 files)

This is follow up of marionette js integration test written for bug 1080090, See https://bugzilla.mozilla.org/show_bug.cgi?id=1080090#c31 With bug 1090817 resolved, we can write test using marionette-file-manager API to add all files in a directory by specifying directory path.
Assignee: nobody → pdahiya
Hi Kevin Please review attached PR to update marionette-file-manager to 0.0.3. This is needed for tests in this bug to load all test images by specifying dir path. See https://bugzilla.mozilla.org/show_bug.cgi?id=1090817#c8 Thanks!
Attachment #8532211 - Flags: review?(kgrandon)
Hi Evan Including you to look at the attached PR (attachment 8532211 [details] [review]) and confirm that it reflects all updates for 0.0.3. Thanks!
Flags: needinfo?(evanxd)
Comment on attachment 8532211 [details] [review] PR to update gaia-node-modules with latest marionette-file-manager R+ stamp for the manifest bumps, though not really needed. Thanks.
Attachment #8532211 - Flags: review?(kgrandon) → review+
Thanks Kevin for review, attaching PR to update gaia node modules revision and package.json. Please review.
Attachment #8532578 - Flags: review?(kgrandon)
Comment on attachment 8532578 [details] [review] PR - Update gaia node modules revision lgtm.
Attachment #8532578 - Flags: review?(kgrandon) → review+
Thanks! updated node modules revision landed on gaia master https://github.com/mozilla-b2g/gaia/commit/56ad5e32eeafa83fcb4ac206ee598cf1480fc807
Flags: needinfo?(evanxd)
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: