Closed
Bug 1092233
Opened 10 years ago
Closed 7 years ago
[Gallery] - Marionette JS Integration test to scan and load test images
Categories
(Firefox OS Graveyard :: Gaia::Gallery, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: pdahiya, Assigned: pdahiya)
Details
Attachments
(3 files)
This is follow up of marionette js integration test written for bug 1080090, See https://bugzilla.mozilla.org/show_bug.cgi?id=1080090#c31
With bug 1090817 resolved, we can write test using marionette-file-manager API to add all files in a directory by specifying directory path.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → pdahiya
Assignee | ||
Comment 1•10 years ago
|
||
Hi Kevin
Please review attached PR to update marionette-file-manager to 0.0.3. This is needed for tests in this bug to load all test images by specifying dir path.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1090817#c8
Thanks!
Attachment #8532211 -
Flags: review?(kgrandon)
Assignee | ||
Comment 2•10 years ago
|
||
Hi Evan
Including you to look at the attached PR (attachment 8532211 [details] [review]) and confirm that it reflects all updates for 0.0.3. Thanks!
Flags: needinfo?(evanxd)
Assignee | ||
Comment 3•10 years ago
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8532211 [details] [review]
PR to update gaia-node-modules with latest marionette-file-manager
R+ stamp for the manifest bumps, though not really needed. Thanks.
Attachment #8532211 -
Flags: review?(kgrandon) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Thanks Kevin for review, attaching PR to update gaia node modules revision and package.json. Please review.
Attachment #8532578 -
Flags: review?(kgrandon)
Comment 6•10 years ago
|
||
Comment on attachment 8532578 [details] [review]
PR - Update gaia node modules revision
lgtm.
Attachment #8532578 -
Flags: review?(kgrandon) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Thanks! updated node modules revision landed on gaia master
https://github.com/mozilla-b2g/gaia/commit/56ad5e32eeafa83fcb4ac206ee598cf1480fc807
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(evanxd)
Comment 8•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•