Closed Bug 1090925 Opened 5 years ago Closed 5 years ago

Add keyboard support to actions

Categories

(Testing :: Marionette, defect, P1)

defect

Tracking

(firefox38 fixed)

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: automatedtester, Assigned: chmanchester)

References

(Blocks 1 open bug, )

Details

(Keywords: pi-marionette-client, pi-marionette-server, Whiteboard: [marionette=1.0])

Attachments

(1 file, 1 obsolete file)

We need to add support for keyboard actions.

This was recently added to the webdriver spec.
Blocks: m21s
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [marionette=1.0]
/r/1719 - Bug 1090925 - Add keyboard support to marionette action chains ("keyDown" and "keyUp")

Pull down this commit:

hg pull review -r 31b492e73d2c94bf9e5b5d49ed261afad5f36c2e
/r/1719 - Bug 1090925 - Add keyboard support to marionette action chains ("keyDown" and "keyUp")

Pull down this commit:

hg pull review -r 9384f44cdb9a3be380137788effd5488ed58c843
Comment on attachment 8541048 [details]
MozReview Request: bz://1090925/chmanchester

My main question at this point is whether these test cases are what is intended by the spec.
Attachment #8541048 - Flags: feedback?(dburns)
Comment on attachment 8541048 [details]
MozReview Request: bz://1090925/chmanchester

Looks good. I think the main item that we want to test in the future is handling mouse down and mouse up while a key is pressed. 

e.g. mousemove(top, left).keydown(shift).mousemove(bottom, right).keyup()

That part can be done at a later stage.
Attachment #8541048 - Flags: feedback?(dburns) → feedback+
Comment on attachment 8541048 [details]
MozReview Request: bz://1090925/chmanchester

/r/1719 - Bug 1090925 - Add keyboard support to marionette action chains ("keyDown" and "keyUp")

Pull down this commit:

hg pull review -r deabf306e480d5ca7137d8ac609ad7d6b4d8cb2c
Attachment #8541048 - Flags: feedback+
Attachment #8541048 - Flags: review?(dburns)
Comment on attachment 8541048 [details]
MozReview Request: bz://1090925/chmanchester

/r/1719 - Bug 1090925 - Add keyboard support to marionette action chains ("keyDown" and "keyUp")

Pull down this commit:

hg pull review -r 1404be612e5fe44c46aecf840d27e603e90feaa6
Assignee: nobody → cmanchester
Comment on attachment 8541048 [details]
MozReview Request: bz://1090925/chmanchester

https://reviewboard.mozilla.org/r/1717/#review2813

This looks good!
Attachment #8541048 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/cf6f18eea5e1
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Priority: -- → P1
Duplicate of this bug: 845848
Duplicate of this bug: 887271
Attachment #8541048 - Attachment is obsolete: true
Attachment #8618498 - Flags: review+
You need to log in before you can comment on or make changes to this bug.