Closed
Bug 1091126
Opened 11 years ago
Closed 11 years ago
Use the toolkit printPreviewBindings.xml instead of ours.
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(seamonkey2.33 fixed)
RESOLVED
FIXED
seamonkey2.33
| Tracking | Status | |
|---|---|---|
| seamonkey2.33 | --- | fixed |
People
(Reporter: philip.chee, Assigned: philip.chee)
References
Details
Attachments
(1 file)
|
15.87 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
The toolkit printPreviewBindings.xml is a fork of the old XPFE printPreviewBindings.xml and of course SeaMonkey inherited XPFE. There are no substantive differences between the two - except that ours does not have the latest fixes: Bug 830342, Bug 968141, and Bug 1082575 (this last currently backed out).
I propose we drop our implementation and just use toolkit. This way we won't need to keep the two synchronized (Bug 1082575 is a significant refactoring), freeing up our code contributors to do other more important stuff.
| Assignee | ||
Comment 1•11 years ago
|
||
Updated•11 years ago
|
Attachment #8515635 -
Flags: review?(neil) → review+
| Assignee | ||
Comment 2•11 years ago
|
||
comm-central changeset 40302dd8b857
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/40302dd8b857
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-seamonkey2.33:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.33
You need to log in
before you can comment on or make changes to this bug.
Description
•