Closed Bug 1091282 Opened 7 years ago Closed 7 years ago

tracking bug for build and release of Firefox and Fennec 33.1

Categories

(Release Engineering :: Release Requests, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Unassigned)

References

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2762] )

Attachments

(5 files)

The anniversary release.
Over in bug 1077643 the in-app code has been modified to show a whatsnew page after the update, just for the locales we have localisation for. This patch will fix up build2 so we don't need to do any manual work on snippets.
Attachment #8514057 - Flags: review?(mgervasini)
Attachment #8514057 - Flags: review?(mgervasini) → review+
Comment on attachment 8514057 [details] [diff] [review]
[tools] Disable whatsnew pages in update system

https://hg.mozilla.org/build/tools/rev/9d9c3aa48db0
Attachment #8514057 - Flags: checked-in+
Note the snippets were tweaked again in bug 1093187.
Depends on: 1093187
Comment on attachment 8516178 [details] [diff] [review]
[tools] offer no opinion on whatsnew page for build 3

Thanks for handling this. The error crept in because we normally swap between whatsnew or no whatsnew entirely in snippets, and this is something new.
Attachment #8516178 - Flags: review?(nthomas) → review+
Comment on attachment 8516178 [details] [diff] [review]
[tools] offer no opinion on whatsnew page for build 3

https://hg.mozilla.org/build/tools/rev/b788321bd4aa
Attachment #8516178 - Flags: checked-in+
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2755]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2755] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2762]
For 33.0.3, I've had to revert the changes we made earlier to the patcher config. This combines attachment 8514057 [details] [diff] [review] and attachment 8516178 [details] [diff] [review], in zero-context way to make it apply as is on top of the incoming 33.0.3 changes. Carrying r+.
Attachment #8517897 - Flags: review+
Build 3 is going to be windows only
Attachment #8518216 - Flags: review?(catlee)
Attachment #8518216 - Flags: review?(catlee) → review+
Attachment #8518216 - Flags: checked-in+
Comment on attachment 8517897 [details] [diff] [review]
[tools] redo 'no opinion' for whatsnew build3

landed with a minor change; removed line 15,
 
 -            openURL   https://www.mozilla.org/%locale%/firefox/33.0.3/whatsnew/?oldversion=%OLD_VERSION%

instead of:

>-            openURL   https://www.mozilla.org/%locale%/firefox/33.0.2/whatsnew/?oldversion=%OLD_VERSION%
Attachment #8517897 - Flags: checked-in+
The diff from FIREFOX_33_1_RELEASE in m-r is:

--- make_incremental_updates.py.ref	2014-11-07 04:47:01.365211362 -0800
+++ make_incremental_updates.py	2014-11-07 02:06:38.355225774 -0800
@@ -434,7 +434,7 @@
     except Exception, exc:
       try:
         m = re.search(
-          '(?P<platform>.+?)\/(?P<locale>.+?)\/(?P<product>\w+)-(?P<version>\w+\.\w+)\.(?P<type>\w+).mar',
+          '(?P<platform>.+?)\/(?P<locale>.+?)\/(?P<product>\w+)-(?P<version>\w+\.\w+(?:\.\w+)?)\.(?P<type>\w+).mar',
         filepath)
         return m.groupdict()
       except:

to cope with x.y.z versioning.
Checked in code deployed to production
Shipped today. Happy 10th Anniversary Firefox!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.