1091308 - When launching Settings via an activity, the status bar color scheme does not change

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

STR:

1. Launch SMS
2. Click the ... menu
3. Click Settings

Expected results:

The status bar should use the "dark" color scheme, like it does if you launch the settings app directly

Actual results:

The status bar is still using the "light" color scheme, as it does for the SMS app.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Screenshot

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

qawanted for branch checks

Comment 3

[Chris Kreinbring [:CKreinbring]]

The bug repros on Flame 2.2 engineering with shallow flash.
Actual result: After selecting Settings from the Messaging app's ... menu, the status bar text will be light making it hard to read on the white bar.

BuildID: 20141029054810
Gaia: a9a847920b51b79c4ad4ad339f0a005777a6228c
Gecko: c6989e473f97
Platform Version: 36.0a1
Firmware Version: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

--------------------------------------------------------------------------------------------------------

The bug does not repro on Flame 2.1 engineering with shallow flash.
Actual result: After selecting Settings from the Messaging app's ... menu, the status bar text will be dark making it easy to read on the white bar.

BuildID: 20141029082611
Gaia: 2099fb0df60548cf7d4afc367f5048622cc29b3e
Gecko: f02f3fbd0bb0
Platform Version: 34.0
Firmware Version: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 4

[Chris Kreinbring [:CKreinbring]]

Regression window
Last working
BuildID: 20141021064010
Gaia: 457a54fc3200b80e4f5e1cd3acaa062309230732
Gecko: 676acfb44e8b
Platform Version: 36.0a1
Firmware Version: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First broken
BuildID: 20141021064810
Gaia: 3ec94f448bb5c1c9c264896685c6ef77ab718c87
Gecko: fe1513fc09f6
Platform Version: 36.0a1
Firmware Version: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Working Gaia / Broken Gecko = No repro
Gaia: 457a54fc3200b80e4f5e1cd3acaa062309230732
Gecko: fe1513fc09f6
Broken Gaia / Working Gecko = Repro
Gaia: 3ec94f448bb5c1c9c264896685c6ef77ab718c87
Gecko: 676acfb44e8b
Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/457a54fc3200b80e4f5e1cd3acaa062309230732...3ec94f448bb5c1c9c264896685c6ef77ab718c87


B2G Inbound
Last working
BuildID: 20141020205719
Gaia: e09e1734ad523cf63351a28f6f84454319349fbe
Gecko: 4da1f6a151d6
Platform Version: 36.0a1
Firmware Version: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First broken
BuildID: 20141020214218
Gaia: ba10744d64411a8a12ae68f7cf1ec3e3ac897d21
Gecko: bcc5df613d83
Platform Version: 36.0a1
Firmware Version: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Working Gaia / Broken Gecko = No repro
Gaia: e09e1734ad523cf63351a28f6f84454319349fbe
Gecko: bcc5df613d83
Broken Gaia / Working Gecko = Repro
Gaia: ba10744d64411a8a12ae68f7cf1ec3e3ac897d21
Gecko: 4da1f6a151d6
Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/e09e1734ad523cf63351a28f6f84454319349fbe...ba10744d64411a8a12ae68f7cf1ec3e3ac897d21

Comment 5

[Joshua Mitchell (Inactive)]

Broken by Bug 1007600 - can you take a look Arthur

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Alive, it seems there are issues when calculating the theme color in app chrome. Any ideas?

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Arthur Chen [:arthurcc] from comment #6)
> Alive, it seems there are issues when calculating the theme color in app
> chrome. Any ideas?

You should specify your theme color in activity page just like in app page.
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/index.html#L6

One line fix!

Comment 8

[Manuel Casas Barrado [:mancas]]

Attachment: First patch

Hey Arthur, as Alive said in the previous comment, we need to change the meta tag of the inline activity. I've noticed that the inline activity doesn't have its own file so, we must update the theme once we receive the activity request.

I don't like the approach I've made, could you give your opinion on that?

Thanks!

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Settings app uses the same page for inline activity. Per the offline discussion with Alive, there are issues related to app chrome. The calculated theme changes during the transition of inline activity. Flagging Michael for inputs.

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #7)
> (In reply to Arthur Chen [:arthurcc] from comment #6)
> > Alive, it seems there are issues when calculating the theme color in app
> > chrome. Any ideas?
> 
> You should specify your theme color in activity page just like in app page.
> https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/index.html#L6
> 
> One line fix!

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8514912 [details] [review]
First patch

Per comment 9, this is not a proper fix. There should be no changes required in settings app.

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

Alberto, can you try and figure out what is happening with theme color changes during inline activity launches?

Comment 12

[Alberto Pastor [:albertopq]]

I'm surprised this didn't get caught by https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/statusbar_icon_color_test.js#L86

I'll take a look.

Comment 13

[Alberto Pastor [:albertopq]]

Stealing, as is a System problem

Comment 14

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25760

Comment 15

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8515902 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25760

LGTM, thanks! I left a comment on github not really related to your patch, but just a thought.

Comment 16

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/6b11299636900190ae47d28a13a418fc6b91cb64

Comment 17

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2.

Result: The status bar icons are displayed in gray on "Messaging Settings" screen from Messages app.

Device: Flame 2.2 (319mb, KK, Shallow Flash)
BuildID: 20141119040205
Gaia: e64428c5b2dce5db90b75a5055077a04f4bd4819
Gecko: bc2c36dda0a9
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0