1091605 - The windows installer bypasses the profile selection logic when it tries to launch the installed app

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Bug 1024110 changed the way profile selection works for aurora builds. However the windows installer does not appear to use that logic when it tries to launch the app after installation.

What ends up happening is that after I use stable Firefox to download the installer, run it and after it's done, click finish (with the "launch Firefox now" checkbox ticked), I see the "Firefox is already running" message, as it tries to use the default profile. Exiting the installer and manually running the newly installed app works fine though.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Rob, do you know how to fix this, or can you point me to the code that launches the app?

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

I think I've found it, the LaunchApp function in installer.nsi seems to be the one I want. I can't follow the command line construction logic however to see what's the eventual command that it executes. I tried using the task manager to find it, but all I see are 2 setup.exe processes that don't carry much more information.

Comment 3

[Robert Strong (they/them - no direct email)]

For the stub installer you will need to skip this
1918   FindWindow $0 "${WindowClass}"
1919   ${If} $0 <> 0 ; integer comparison
1920     StrCpy $FirefoxLaunchCode "1"
1921     MessageBox MB_OK|MB_ICONQUESTION "$(WARN_MANUALLY_CLOSE_APP_LAUNCH)"
1922     Return
1923   ${EndIf}
http://mxr.mozilla.org/mozilla-central/source/browser/installer/windows/nsis/stub.nsi#1918

For the full installer you will need to skip this
772   ${ManualCloseAppPrompt} "${WindowClass}" "$(WARN_MANUALLY_CLOSE_APP_LAUNCH)"
http://mxr.mozilla.org/mozilla-central/source/browser/installer/windows/nsis/installer.nsi#772

I think the following should accomplish what you want.

add the following to defines.nsi.in
#ifdef DEV_EDITION
!define DEV_EDITION
#endif

and around the blocks mentioned above add
!ifndef DEV_EDITION
  FindWindow $0 "${WindowClass}"
  ${If} $0 <> 0 ; integer comparison
    StrCpy $FirefoxLaunchCode "1"
    MessageBox MB_OK|MB_ICONQUESTION "$(WARN_MANUALLY_CLOSE_APP_LAUNCH)"
    Return
  ${EndIf}
!endif

!ifndef DEV_EDITION
  ${ManualCloseAppPrompt} "${WindowClass}" "$(WARN_MANUALLY_CLOSE_APP_LAUNCH)"
!endif

Comment 4

[Robert Strong (they/them - no direct email)]

Another option would be to just add the following to Aurora's branding.nsi
!define DEV_EDITION

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: The windows installer shouldn't bypasses the profile selection logic when it tries to launch the installed app

OK, all that make sense. I've pushed this patch to gum and will report back when I've tested the resulting builds.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

I'm happy to report the patch seems to have fixed the issue!

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/1bf7c3275367

Comment 8

[Robert Strong (they/them - no direct email)]

Yay!

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1bf7c3275367

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8514921 [details] [diff] [review]
The windows installer shouldn't bypasses the profile selection logic when it tries to launch the installed app

Approval Request Comment
[Feature/regressing bug #]: bug 1024110
[User impact if declined]: launching Aurora from the Windows installer will not work properly
[Describe test coverage new/current, TBPL]: manual testing on m-c, gum
[Risks and why]: this is a minor build-time configuration change
[String/UUID change made/needed]: none

Comment 11

[Camelia Badau [:cbadau], Desktop Test Engineering]

I found an issue and I filled bug 1094299.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a361f7b59686

Comment 13

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed with latest gum build (buildID: 20141106161710).

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2f7dd54a6f49