1091644 - Marking Ship It on a single review request for a series with 1 commit should update parent review request

Status: RESOLVED DUPLICATE of bug 1055021

(MozReview Graveyard :: General, defect, P1)

Description

[(no longer active)]

See for example bug 1091312.

Comment 1

[Steven MacLeod [:smacleod]]

We will only set r+ if you mark a Ship-It on the parent review request (So, in a multi commit review request you need to sign off on the parent to say the whole thing is r+).

This is awkward when the code is only a single commit, as we still create two review requests. Making this better is a high priority, see Bug 1039679

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!, PTO 11/3-11/21) from comment #0)
> See for example bug 1091312.

In this specific case if you'd like to r+ you need to Ship-It on https://reviewboard.mozilla.org/r/57/

Comment 2

[Steven MacLeod [:smacleod]]

This is probably worth documenting in the mean time though.

Comment 3

[(no longer active)]

This makes sense, but one question though: how close is bug 1039679?  One commit review requests are a an extremely common case, so if you think that bug 1039679 is long ways away, we may want to do something here in the mean time.

Comment 4

[Gregory Szorc [:gps]]

This is already documented at https://mozilla-version-control-tools.readthedocs.org/en/latest/mozreview/reviewboard.html#two-types-of-ship-its.

I think bug 1039679 requires quite a bit of bikeshedding and consideration before we go down that road. I'd be in favor of making Ship It on a commit's review request automagically add a Ship It to the parent review request in the case of a single commit series.

Should we reopen this bug and implement that?

Comment 5

[(no longer active)]

Yes, that makes sense to me.

Comment 6

[Gregory Szorc [:gps]]

I'll have a go at this.

Comment 8

[Mark Côté [:mcote]]

WONTFIX because we're going with one flag per commit (bug 1055021).

Comment 9

[Gregory Szorc [:gps]]

Bug 1055021 is a superior solution.