1091901 - Tracking Protection: no HiDPI friendly icon in preferences

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Sören Hentzschel]

Attachment: screenshot

The shield icon in the preferences for the tracking protection is not HiDPI friendly.

Comment 1

[:Gijs (out for now; he/him)]

The assets are there ( chrome://browser/skin/[e-mail] resolves in current OS X nightly), but they'd be tricky to apply in the current chrome structure, considering they're hardcoded in the XUL...

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 3

[:Gijs (out for now; he/him)]

Comment on attachment 8515682 [details] [diff] [review]
patch

Review of attachment 8515682 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/incontentprefs/preferences.css
@@ +296,5 @@
>  }
>  
> +#trackingProtectionImage {
> +  width: 16px;
> +  height: 16px;

Nit: do you really need to set both the height/width? I would have assumed either would have sufficed.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/fx-team/rev/68fe119fa995

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to :Gijs Kruitbosch from comment #3)
> Nit: do you really need to set both the height/width? I would have assumed
> either would have sufficed.

Perhaps not, but it seems confusing/pointless to only set one, so I left this as-is.

Comment 6

[Richard Marti (:Paenglab)]

The rule is set in shared file. On Windows, when scale is set to 200%, there would be no icon shown because it is only shipped on OS X.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/68fe119fa995