Tracking Protection: no icon in preferences when using 2dppi on non-OSX

RESOLVED FIXED in Firefox 37

Status

()

Firefox
Theme
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
Firefox 37
All
Windows 8.1
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite -
qe-verify -

Firefox Tracking Flags

(firefox36 affected, firefox37 affected)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1091901 +++

The shield icon in the preferences for the tracking protection is now HiDPI friendly, but is applied in CSS that's shared, while the icon is only shipped on OS X. I should have caught this in review on bug 1091901. :-(
(Assignee)

Updated

3 years ago
Iteration: 36.2 → ---
Points: --- → 1
Flags: qe-verify-
Flags: in-testsuite-
Flags: firefox-backlog+
(Assignee)

Comment 1

3 years ago
Created attachment 8528358 [details] [diff] [review]
ship bad-content-16@2x on Linux/Windows,

Seems the other in-content stuff does hidpi on linux/windows as well, so this probably should, too.
Attachment #8528358 - Flags: review?(jaws)
(Assignee)

Updated

3 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Comment on attachment 8528358 [details] [diff] [review]
ship bad-content-16@2x on Linux/Windows,

Except that the file doesn't exist...
Attachment #8528358 - Attachment is obsolete: true
Attachment #8528358 - Flags: review?(jaws)

Updated

3 years ago
Iteration: --- → 37.1
(Assignee)

Comment 3

3 years ago
Created attachment 8528378 [details] [diff] [review]
Patch v2

Just moved all the images to shared/ considering they're the same anyway. Used the Windows ones where available because they've been optimized by bug 1062969.
(Assignee)

Comment 4

3 years ago
Comment on attachment 8528378 [details] [diff] [review]
Patch v2

Review of attachment 8528378 [details] [diff] [review]:
-----------------------------------------------------------------

Note that splinter doesn't get the hg moves/renames right, apparently. :-\
Attachment #8528378 - Flags: review?(jaws)
Comment on attachment 8528378 [details] [diff] [review]
Patch v2

Review of attachment 8528378 [details] [diff] [review]:
-----------------------------------------------------------------

I looked at the patch file directly to see the hg moves/renames. Yeah, it would be nice if Splinter handled it better. Do you know if ReviewBoard does this right? If not, we should probably get a bug on file for either Splinter or Review Board (or both!) :)
Attachment #8528378 - Flags: review?(jaws) → review+
(Assignee)

Updated

3 years ago
status-firefox36: --- → affected
status-firefox37: --- → affected
(Assignee)

Comment 7

3 years ago
Created attachment 8532080 [details]
MozReview Request: bz://1104730/Gijs
(Assignee)

Comment 8

3 years ago
/r/1139 - Bug 1104730 - ship bad-content-16@2x on Linux/Windows, r=jaws

Pull down this commit:

hg pull review -r 4a388c2d87c516319bb0ca2b4169b6de88f2ed8f
(Assignee)

Comment 9

3 years ago
(In reply to :Gijs Kruitbosch from comment #8)
> /r/1139 - Bug 1104730 - ship bad-content-16@2x on Linux/Windows, r=jaws
> 
> Pull down this commit:
> 
> hg pull review -r 4a388c2d87c516319bb0ca2b4169b6de88f2ed8f

So this is the reviewboard alternative. It doesn't make stuff up, but it does fail at indicating *any* renames, that I can see. :-\
https://hg.mozilla.org/mozilla-central/rev/4a388c2d87c5
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
(Assignee)

Comment 11

3 years ago
Comment on attachment 8532080 [details]
MozReview Request: bz://1104730/Gijs
Attachment #8532080 - Attachment is obsolete: true
(Assignee)

Comment 12

3 years ago
Created attachment 8618719 [details]
MozReview Request: Bug 1104730 - ship bad-content-16@2x on Linux/Windows, r=jaws
You need to log in before you can comment on or make changes to this bug.