1104730 - Tracking Protection: no icon in preferences when using 2dppi on non-OSX

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[:Gijs (he/him)]

+++ This bug was initially created as a clone of Bug #1091901 +++

The shield icon in the preferences for the tracking protection is now HiDPI friendly, but is applied in CSS that's shared, while the icon is only shipped on OS X. I should have caught this in review on bug 1091901. :-(

Comment 1

[:Gijs (he/him)]

Attachment: ship bad-content-16@2x on Linux/Windows,

Seems the other in-content stuff does hidpi on linux/windows as well, so this probably should, too.

Comment 2

[:Gijs (he/him)]

Comment on attachment 8528358 [details] [diff] [review]
ship bad-content-16@2x on Linux/Windows,

Except that the file doesn't exist...

Comment 3

[:Gijs (he/him)]

Attachment: Patch v2

Just moved all the images to shared/ considering they're the same anyway. Used the Windows ones where available because they've been optimized by bug 1062969.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8528378 [details] [diff] [review]
Patch v2

Review of attachment 8528378 [details] [diff] [review]:
-----------------------------------------------------------------

Note that splinter doesn't get the hg moves/renames right, apparently. :-\

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8528378 [details] [diff] [review]
Patch v2

Review of attachment 8528378 [details] [diff] [review]:
-----------------------------------------------------------------

I looked at the patch file directly to see the hg moves/renames. Yeah, it would be nice if Splinter handled it better. Do you know if ReviewBoard does this right? If not, we should probably get a bug on file for either Splinter or Review Board (or both!) :)

Comment 6

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/4a388c2d87c5

Comment 7

[:Gijs (he/him)]

Attachment: MozReview Request: bz://1104730/Gijs

Comment 8

[:Gijs (he/him)]

/r/1139 - Bug 1104730 - ship bad-content-16@2x on Linux/Windows, r=jaws

Pull down this commit:

hg pull review -r 4a388c2d87c516319bb0ca2b4169b6de88f2ed8f

Comment 9

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #8)
> /r/1139 - Bug 1104730 - ship bad-content-16@2x on Linux/Windows, r=jaws
> 
> Pull down this commit:
> 
> hg pull review -r 4a388c2d87c516319bb0ca2b4169b6de88f2ed8f

So this is the reviewboard alternative. It doesn't make stuff up, but it does fail at indicating *any* renames, that I can see. :-\

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4a388c2d87c5

Comment 12

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1104730 - ship bad-content-16@2x on Linux/Windows, r=jaws