If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[MSE] MP4Reader::NotifyDataArrived() should not dispatch to a separate thread

RESOLVED FIXED in mozilla36

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kentuckyfriedtakahe, Assigned: kentuckyfriedtakahe)

Tracking

Trunk
mozilla36
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

MP4Reader::NotifyDataArrived() currently dispatches UpdateIndex() to a separate thread. This causes updates to MP4Reader::GetBuffered() to be delayed which in turn breaks MSE buffer switching.
Created attachment 8514737 [details] [diff] [review]
Process MP4Reader::NotifyDataArrived() immediately
Assignee: nobody → ajones
Status: NEW → ASSIGNED
Created attachment 8514739 [details] [diff] [review]
Process MP4Reader::NotifyDataArrived() immediately
Attachment #8514737 - Attachment is obsolete: true
Created attachment 8514744 [details] [diff] [review]
Process MP4Reader::NotifyDataArrived() immediately
Attachment #8514739 - Attachment is obsolete: true
Attachment #8514744 - Flags: review?(edwin)
Comment on attachment 8514744 [details] [diff] [review]
Process MP4Reader::NotifyDataArrived() immediately

Review of attachment 8514744 [details] [diff] [review]:
-----------------------------------------------------------------

This, but in reverse: http://mozillamemes.tumblr.com/post/45116480402/could-we-could-we-put-them-in-the-cloud

What could possibly go wrong?
Attachment #8514744 - Flags: review?(edwin) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/6592c05a4bb2
https://hg.mozilla.org/mozilla-central/rev/6592c05a4bb2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.