Closed Bug 1081817 Opened 6 years ago Closed 6 years ago

Enable MSE with MP4 content

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(3 obsolete files)

Right now, only webm container is active with MSE.

You have to set the media.mediasource.ignore_codecs to true so you can use MP4.

MSE should be enabled by default for MP4 content and not just WEBM.
Attached patch Enable MP4 MIME type with MSE (obsolete) — Splinter Review
Enable mp4 with MSE to work without the need with media.mediasource.ignore_codecs
Attachment #8503902 - Flags: review?(ajones)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
We only want to do this once MP4 is working as well as WebM.
Comment on attachment 8503902 [details] [diff] [review]
Enable MP4 MIME type with MSE

Review of attachment 8503902 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/mediasource/MediaSource.cpp
@@ +78,1 @@
>  #endif

Remove duplication so we've just got a small |#ifndef MOZ_GONK_MEDIACODEC| section for webm.
Attachment #8503902 - Flags: review?(ajones) → review+
Attached patch Enable MP4 MIME type with MSE (obsolete) — Splinter Review
Carrying r+
Attachment #8503902 - Attachment is obsolete: true
OS: Mac OS X → All
Hardware: x86 → All
Attached patch Enable MP4 MIME type with MSE (obsolete) — Splinter Review
Rebase
Attachment #8504416 - Attachment is obsolete: true
Comment on attachment 8517827 [details] [diff] [review]
Enable MP4 MIME type with MSE

obsolete with landing of 1092096
Attachment #8517827 - Attachment is obsolete: true
Depends on: 1096184
This bug is necessary for basic playback of EME video on Windows.
Blocks: eme-m1
No longer depends on: 1082155
(In reply to Chris Peterson (:cpeterson) from comment #7)
> This bug is necessary for basic playback of EME video on Windows.

We've enabled MP4 on Windows in a separate bug.
No longer blocks: eme-m1
Depends on: 1105115
We can close this bug.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Mass update firefox-status to track EME uplift.
You need to log in before you can comment on or make changes to this bug.