1092095 - Can't seek MP4 files that don't contain a sidx box

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

MP4 files without a sidx box can't seek. This includes MSE segments where the spec requires us to ignore the sidx so even if it is there we shouldn't use it.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Support MP4 seeking without sidx

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Support MP4 seeking without sidx

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Support MP4 seeking without sidx

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a5ad9a8e25a6

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

I'll land it myself now that inbound is open again.

Comment 6

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e37ad545154

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2e37ad545154

Comment 8

[Sudhir]

If this issue is fixed. Can I pick this bug for testing? If so, please let me know the test-steps for the same.

Comment 9

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

(In reply to Sudhir from comment #8)
> If this issue is fixed. Can I pick this bug for testing? If so, please let
> me know the test-steps for the same.

I'm not sure it is easy to test unless you've got good tools for creating MP4 files. You'd need a video without a sidx box, otherwise it breaks seeking in MP4 playback of MSE.