Closed
Bug 1092161
Opened 10 years ago
Closed 10 years ago
Short string codes are not recognized as MMI numbers
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(blocking-b2g:2.0M+, b2g-v1.4 affected, b2g-v2.0 affected, b2g-v2.0M fixed, b2g-v2.1 fixed, b2g-v2.2 fixed)
People
(Reporter: gsvelto, Assigned: gsvelto)
References
Details
Attachments
(2 files)
2.46 KB,
patch
|
drs
:
review+
fabrice
:
approval-gaia-v2.1+
|
Details | Diff | Splinter Review |
46 bytes,
text/x-github-pull-request
|
Details | Review |
3GPP TS 22.030 [1] 6.5.3.2 sub-clause 4 mandates that "Entry of 1 or 2 characters defined in the 3GPP TS 23.038 [8] Default Alphabet followed by SEND" should be considered MMI codes. Currently we don't detect these type of numbers as MMI codes and treat them as regular calls. This problem will be solved once bug 1031175 lands on master; however that bug is large, has lots of dependencies and is quite regression-prone making it unsuitable for uplift to 2.0 and 2.1. In this bug I propose to land a quick, simple fix to recognize those numbers using the current logic in MmiManager.isMMI() to address this issue in a way that is low-risk and amenable to be uplifted to 2.0 and 2.1. [1] http://www.3gpp.org/DynaReport/22030.htm
Assignee | ||
Updated•10 years ago
|
status-b2g-v1.4:
--- → affected
status-b2g-v2.0:
--- → affected
status-b2g-v2.0M:
--- → affected
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → affected
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
[Blocking Requested - why for this release]: Requested by a vendor in bug 1087241. I've opened this bug to address the most important part of the problems that would be addressed in bug 1031175 with a smaller, dependency-free patch that is easy to uplift and virtually risk-free.
blocking-b2g: --- → 2.0?
Updated•10 years ago
|
Attachment #8514981 -
Flags: review?(drs.bugzilla) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Thanks for the quick review, waiting for the try run to turn green before merging: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=07b4b27e31fa
Assignee | ||
Comment 5•10 years ago
|
||
I had to re-trigger a job but now we're green. Pushed to gaia/master 0385c0fe75ad2c4ff01e4be54af176f6ce9e486a https://github.com/mozilla-b2g/gaia/commit/0385c0fe75ad2c4ff01e4be54af176f6ce9e486a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
blocking-b2g: 2.0? → 2.0M+
Comment 6•10 years ago
|
||
Per https://bugzilla.mozilla.org/show_bug.cgi?id=1087241#c6 Hi Kai-Zhen, Could you please help to land on 2.0M? Thanks!
Blocks: Woodduck
Flags: needinfo?(kli)
Comment 7•10 years ago
|
||
Ryan, The tree seems closed, could you help me? Thanks!
Flags: needinfo?(kli) → needinfo?(ryanvm)
Comment 8•10 years ago
|
||
v2.0m: https://github.com/mozilla-b2g/gaia/commit/65bb12d7e1e121cb455c00b22ae521e920fef97e
Flags: needinfo?(ryanvm)
Comment 9•10 years ago
|
||
Does this need to land on v2.1 as well? Please nominate for Gaia v2.1 approval if so :)
Flags: needinfo?(gsvelto)
Target Milestone: --- → 2.1 S8 (7Nov)
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8514981 [details] [diff] [review] [PATCH] Properly handle MMI short-string codes [Approval Request Comment] [Bug caused by] (feature/regressing bug #): - [User impact] if declined: Short string MMI codes are not recognized correctly [Testing completed]: Tested on a device and covered with unit-tests [Risk to taking this patch] (and alternatives if risky): Not implement this and wait for bug 1031175 to land [String changes made]: None
Flags: needinfo?(gsvelto)
Attachment #8514981 -
Flags: approval-gaia-v2.1?(release-mgmt)
Updated•10 years ago
|
Attachment #8514981 -
Flags: approval-gaia-v2.1?(release-mgmt) → approval-gaia-v2.1+
Comment 11•10 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/bcaa487caddc85877b1645a1d5ac30a2d2c9801c
You need to log in
before you can comment on or make changes to this bug.
Description
•