1092195 - Investigate failure in test_cost_control_ftu.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Viorela Ioia [:viorela]]

Test test_cost_control_ftu.py has failed in latest master: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.ui.functional.non-smoke/93/HTML_Report/
It's also failing locally, while running the automated test. It is not failing manually.

As I noticed, we need to update a locator in keyboard app: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py#L76

Comment 1

[Viorela Ioia [:viorela]]

I've been investigating this failure, and I got some info. The issue here is that current_input_type (https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py#L122) returns text, instead of number, even though the number keyboard is displayed. 

First build when we saw this issue happening:
Device firmware (date) 	30 Oct 2014 16:22:57
Device firmware (incremental) 	eng.cltbld.20141030.192246
Device firmware (release) 	4.4.2
Device identifier 	flame
Gaia date 	30 Oct 2014 10:56:06
Gaia revision 	8ae6598f3ab7
Gecko build 	20141030160200
Gecko revision 	e0b505a37b1c
Gecko version 	36.0a1
Bootloader      L1TC00011880

Jenkins report: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.ui.functional.non-smoke/92/HTML_Report/

Tim, any idea what happened here? The script we use to get the current input type is: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py#L149.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

What's the window for Gaia and Gecko? Let's find the regression to isolate the issue.

The function in question is here:
https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/keyboard/keyboard_app.js#L143-L176

It's possible we lost the inputContext at that point.

Comment 3

[Viorela Ioia [:viorela]]

Regression range, based on b2g-i:
Last working:
Gaia-Rev        86b3cdf8bc50698a58e01dccd63f5c7318e02d8a
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/7d4b9c10b746
Build-ID        20141030082817
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141030.115924
FW-Date         Thu Oct 30 11:59:35 EDT 2014
Bootloader      L1TC00011880

First failing: 
Gaia-Rev        92cb5d84a3558159a0d7f513cc777ce7e58ca10c
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/30917fc0c535
Build-ID        20141030085017
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141030.122728
FW-Date         Thu Oct 30 12:27:39 EDT 2014
Bootloader      L1TC00011880

Gaia pushlog: 
https://github.com/mozilla-b2g/gaia/compare/86b3cdf8bc50698a58e01dccd63f5c7318e02d8a...92cb5d84a3558159a0d7f513cc777ce7e58ca10c

I suppose the commit that broke this test is: https://github.com/mozilla-b2g/gaia/commit/4b7a96e08cbbfef0f52ca05929c5e0f539644d71

I'm working on a fix

Comment 4

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/25835

Comment 5

[Zac C (:zac)]

This was caused by this patch:
https://github.com/mozilla-b2g/gaia/commit/4b7a96e08cbbfef0f52ca05929c5e0f539644d71

Comment 6

[Zac C (:zac)]

Comment on attachment 8517455 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/25835

not r-, but can you re-do this to exclude the `not` conditions?

Comment 7

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/4dadfd1ce0d8d799ca96ee11854e1e31f72b7ebf

Comment 8

[Kevin Grandon :kgrandon]

Reverted for being the likely culprit of bug 1095471. (The same error seems present in the try run)

https://github.com/mozilla-b2g/gaia/commit/57131722d44e93691f667115d060cb1e69dd2cf6

Comment 9

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/25996

Comment 10

[Viorela Ioia [:viorela]]

Merged in: https://github.com/mozilla-b2g/gaia/commit/c1f97d511b199998ce002d1c2c1fa78435687141