Closed
Bug 1092260
Opened 10 years ago
Closed 10 years ago
Some AMD drivers seem to have an extra frame of delay
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
Attachments
(1 file, 3 obsolete files)
3.50 KB,
patch
|
bas.schouten
:
review+
lsblakk
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
In the reproduction we've seen of bug 1089183 we've discovered that the AMD driver doesn't seem to present the current frame until you call Present() for the next frame. This is easily reproducible by typing into the input box at the following URL: data:text/html,<textarea>
Assignee | ||
Comment 1•10 years ago
|
||
I was able to reproduce this with a simple D3D11 test case. I was able to reproduce the same thing with a port of the D3D11 test case to D3D10.
Assignee | ||
Comment 2•10 years ago
|
||
Turns out this was a wild goose chase. The same problem reproduces in IE11 as well as Firefox 25.
Assignee | ||
Comment 3•10 years ago
|
||
This looks it might be the same as https://code.google.com/p/chromium/issues/detail?id=402134
Assignee | ||
Comment 4•10 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: OMTC [User impact if declined]: Delayed by frame [Risks and why]: Low. just modifying a block list
Attachment #8524055 -
Flags: review?(bas)
Attachment #8524055 -
Flags: approval-mozilla-beta?
Attachment #8524055 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 5•10 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: OMTC [User impact if declined]: Delayed by frame [Risks and why]: Low. just modifying a block list
Attachment #8524061 -
Flags: review?(bas)
Attachment #8524061 -
Flags: approval-mozilla-beta?
Attachment #8524061 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 6•10 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: [Describe test coverage new/current, TBPL]: [Risks and why]: [String/UUID change made/needed]: Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: [Describe test coverage new/current, TBPL]: [Risks and why]: [String/UUID change made/needed]: Approval Request Comment [Feature/regressing bug #]: OMTC [User impact if declined]: Delayed by frame [Risks and why]: Low. just modifying a block list
Attachment #8524055 -
Attachment is obsolete: true
Attachment #8524061 -
Attachment is obsolete: true
Attachment #8524055 -
Flags: review?(bas)
Attachment #8524055 -
Flags: approval-mozilla-beta?
Attachment #8524055 -
Flags: approval-mozilla-aurora?
Attachment #8524061 -
Flags: review?(bas)
Attachment #8524061 -
Flags: approval-mozilla-beta?
Attachment #8524061 -
Flags: approval-mozilla-aurora?
Attachment #8524064 -
Flags: review?(bas)
Attachment #8524064 -
Flags: approval-mozilla-beta?
Attachment #8524064 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8524064 [details] [diff] [review] Block D3D11 layers on AMD hardware that delays by a frame Review of attachment 8524064 [details] [diff] [review]: ----------------------------------------------------------------- Bas verbally r+
Attachment #8524064 -
Flags: review?(bas) → review+
Updated•10 years ago
|
status-firefox33:
--- → wontfix
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → affected
tracking-firefox34:
--- → +
tracking-firefox35:
--- → +
tracking-firefox36:
--- → +
Comment 8•10 years ago
|
||
Comment on attachment 8524064 [details] [diff] [review] Block D3D11 layers on AMD hardware that delays by a frame Discussed with Jeff. The current state is that the browser is pretty much unusable for affected gfx hardware as the current frame is only displayed when the subsequent from should be. This makes things like form entry very difficult. Beta+ Aurora+
Attachment #8524064 -
Flags: approval-mozilla-beta?
Attachment #8524064 -
Flags: approval-mozilla-beta+
Attachment #8524064 -
Flags: approval-mozilla-aurora?
Attachment #8524064 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/141ecbdcdb45
Comment 10•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2a254799e303 https://hg.mozilla.org/releases/mozilla-beta/rev/14159808f8ca
Seems like we could work around this if we wanted to.
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/141ecbdcdb45
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Assignee | ||
Comment 13•10 years ago
|
||
Looks like this is fixed by passing the PREVENT_INTERNAL_THREADING_OPTIMIZATIONS flag on device creation: https://tbpl.mozilla.org/?tree=Try&rev=815f50bb7696
Assignee | ||
Comment 14•10 years ago
|
||
Attachment #8524064 -
Attachment is obsolete: true
Attachment #8524796 -
Flags: review?(bas)
Updated•10 years ago
|
Attachment #8524796 -
Flags: review?(bas) → review+
Assignee | ||
Comment 15•10 years ago
|
||
Comment on attachment 8524796 [details] [diff] [review] D3D11_CREATE_DEVICE_PREVENT_INTERNAL_THREADING_OPTIMIZATIONS Approval Request Comment [Feature/regressing bug #]: OMTC [User impact if declined]: black listed hardware acceleration, slow performance if the blacklist isn't correct [Describe test coverage new/current, TBPL]: Any drawing will test this path [Risks and why]: Who knows what D3D11_CREATE_DEVICE_PREVENT_INTERNAL_THREADING_OPTIMIZATIONS does.
Attachment #8524796 -
Flags: approval-mozilla-beta?
Attachment #8524796 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8524796 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 16•10 years ago
|
||
Should this bug have been reopened cat comment 13? Does the latest patch need to land on m-c as well as aurora and beta?
Flags: needinfo?(jmuizelaar)
Comment 17•10 years ago
|
||
Jeff - Can you handle the landings yourself on Wed?
Comment 18•10 years ago
|
||
Comment on attachment 8524796 [details] [diff] [review] D3D11_CREATE_DEVICE_PREVENT_INTERNAL_THREADING_OPTIMIZATIONS Beta+
Attachment #8524796 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 20•10 years ago
|
||
Comment on attachment 8524796 [details] [diff] [review] D3D11_CREATE_DEVICE_PREVENT_INTERNAL_THREADING_OPTIMIZATIONS Resetting Beta flag. Jeff and I are going to review this fix Thu morning after it has a day on Nightly.
Attachment #8524796 -
Flags: approval-mozilla-beta+ → approval-mozilla-beta?
Assignee | ||
Comment 21•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/3e38373768ad
Flags: needinfo?(jmuizelaar)
Updated•10 years ago
|
Comment 23•10 years ago
|
||
Opps, I didn't set the author for that patch when rebasing =\.
Comment 24•10 years ago
|
||
Comment on attachment 8524796 [details] [diff] [review] D3D11_CREATE_DEVICE_PREVENT_INTERNAL_THREADING_OPTIMIZATIONS I reviewed this bug with Jeff this morning and gave verbal approval to land. The fix has been verified by people who were experiencing the issue. This has also been on m-c and m-a for a day or so with no known fallout. We're going to take this fix in beta11. Beta+
Attachment #8524796 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•