Closed
Bug 1092340
Opened 10 years ago
Closed 9 years ago
Remove initializeProfile from automation.py.in
Categories
(Testing :: General, defect)
Testing
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1177780
People
(Reporter: jgriffin, Assigned: harshjha2006, Mentored)
References
Details
(Whiteboard: [good first bug][lang=python])
Attachments
(1 file)
3.50 KB,
patch
|
jgriffin
:
review-
|
Details | Diff | Splinter Review |
This method has no consumers: http://dxr.mozilla.org/mozilla-central/search?q=initializeProfile&case=false
Can you please paste the repository link? I have worked with git/github before but never with Hg, I hope commands are almost the same. Thanks!
Flags: needinfo?(jgriffin)
Reporter | ||
Comment 2•10 years ago
|
||
They're similar, but different. :) See https://developer.mozilla.org/en-US/docs/Mercurial for a guide.
Flags: needinfo?(jgriffin)
Hi Jonathan, please paste the code repo link. Thanks!
Flags: needinfo?(jgriffin)
Reporter | ||
Comment 4•10 years ago
|
||
http://hg.mozilla.org/mozilla-central/ Note this repo is ~1 GB.
Flags: needinfo?(jgriffin)
Attachment #8517875 -
Flags: review?(jgriffin)
Reporter | ||
Comment 6•10 years ago
|
||
thanks for the patch! pushed to try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=52cfa71a61c4
Reporter | ||
Comment 7•10 years ago
|
||
Comment on attachment 8517875 [details] [diff] [review] bug-1092340.patch Review of attachment 8517875 [details] [diff] [review]: ----------------------------------------------------------------- try looks good! Can you give this a commit message in the format described at https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#Commit_Message_Conventions ? I can then land it.
Attachment #8517875 -
Flags: review?(jgriffin) → review-
Comment 8•10 years ago
|
||
Harsh, can you finish up this patch with a commit message? When that is uploaded, I would be happy to run it through try server again, and then get it landed
Flags: needinfo?(harshjha2006)
Hi Jonathan, Is there a way to add a commit message to an existing patch? Thanks.
Flags: needinfo?(harshjha2006) → needinfo?(jgriffin)
Comment 10•10 years ago
|
||
Harsh, you can take the patch, import it into your queue and push it so it is active. Then do a 'hg qrefresh -e' and that will take you to an editor where you can out the comment. A typical comment for this bug would be: Bug 1092340 - Remove initializeProfile from automation.py.in. r=jgriffin Also make sure you have your user setup correctly in hg, or edit the patch with 'hg qrefresh -u "Harsh <harshjha2006@gmail.com>" Of course you can chose the specific name you prefer.
Flags: needinfo?(jgriffin)
Comment 11•9 years ago
|
||
Hi, is this bug still being worked on? I'm new and this looks like a good first bug.
Flags: needinfo?(jgriffin)
Comment 12•9 years ago
|
||
Looks like it's already gone.
Reporter | ||
Comment 13•9 years ago
|
||
This was just fixed as part of another bug, but thanks for asking!
Reporter | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(jgriffin)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•