Closed Bug 1177780 Opened 4 years ago Closed 4 years ago

remove useless stuff in automation.py

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(firefox41 fixed, firefox42 affected)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed
firefox42 --- affected

People

(Reporter: parkouss, Assigned: parkouss)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Well basically I *think* that there are things that could be just removed in this file (build/automation.py). So let's remove that before going on more complicated things, like moving used code into mozbase.
Pushed to try my first attempt here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=45cd16a270c3

Seems good, I'll ask a review soon.
Assignee: nobody → j.parkouss
Bug 1177780 - remove useless stuff in automation.py. r?ahal
Attachment #8627070 - Flags: review?(jgriffin)
I can not assign :ahal for this review (PTO week), so I picked you Jonathan - I hope it is ok. :)

I ran a try run first (:ahal helped me on the right try command to use here), see comment 1. It seems good - 1 build failed, but seems not related. I just restarted that build anyway.
Yep, that's fine, thanks Julien.
Attachment #8627070 - Flags: review?(jgriffin) → review+
Comment on attachment 8627070 [details]
MozReview Request: Bug 1177780 - remove useless stuff in automation.py. r?ahal

https://reviewboard.mozilla.org/r/12183/#review10651

Nice, and thanks!
https://hg.mozilla.org/mozilla-central/rev/f4688e6d0238
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Blocks: 1165263
Duplicate of this bug: 1092340
You need to log in before you can comment on or make changes to this bug.