Closed
Bug 1177780
Opened 10 years ago
Closed 10 years ago
remove useless stuff in automation.py
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(firefox41 fixed, firefox42 affected)
RESOLVED
FIXED
mozilla41
People
(Reporter: parkouss, Assigned: parkouss)
References
Details
Attachments
(1 file)
Well basically I *think* that there are things that could be just removed in this file (build/automation.py). So let's remove that before going on more complicated things, like moving used code into mozbase.
Assignee | ||
Comment 1•10 years ago
|
||
Pushed to try my first attempt here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=45cd16a270c3
Seems good, I'll ask a review soon.
Assignee: nobody → j.parkouss
Assignee | ||
Comment 2•10 years ago
|
||
Bug 1177780 - remove useless stuff in automation.py. r?ahal
Attachment #8627070 -
Flags: review?(jgriffin)
Assignee | ||
Comment 3•10 years ago
|
||
I can not assign :ahal for this review (PTO week), so I picked you Jonathan - I hope it is ok. :)
I ran a try run first (:ahal helped me on the right try command to use here), see comment 1. It seems good - 1 build failed, but seems not related. I just restarted that build anyway.
Comment 4•10 years ago
|
||
Yep, that's fine, thanks Julien.
Updated•10 years ago
|
Attachment #8627070 -
Flags: review?(jgriffin) → review+
Comment 5•10 years ago
|
||
Comment on attachment 8627070 [details]
MozReview Request: Bug 1177780 - remove useless stuff in automation.py. r?ahal
https://reviewboard.mozilla.org/r/12183/#review10651
Nice, and thanks!
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•