Closed
Bug 1092345
Opened 10 years ago
Closed 10 years ago
The keyed histogram section in about:telemetry needs style improvements
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: gfritzsche, Assigned: arky)
References
Details
Attachments
(1 file)
|
959 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Bug 1092176 added a section for keyed histograms, but the layout is still a bit broken.
|
Reporter | |
Comment 2•10 years ago
|
||
Testing around with arky today shows that adding |overflow: hidden| for the keyed-histograms makes layout sane.
A little surprising for me, but arky may pick this bug up.
|
|
Reporter | |
Comment 3•10 years ago
|
||
Arky has a patch for this coming up, re-assigning.
Assignee: georg.fritzsche → hitmanarky
Status: NEW → ASSIGNED
|
Assignee | |
Comment 4•10 years ago
|
||
The simple CSS patch makes the keyed histograms layout consistent.
Attachment #8523500 -
Flags: review?(nfroyd)
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8523500 [details] [diff] [review]
Telemetry-Keyedhistogram-CSS.patch
Review of attachment 8523500 [details] [diff] [review]:
-----------------------------------------------------------------
Given Georg says the layouts are OK, I'm going to trust him. r=me
Attachment #8523500 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Thanks Nathan, Adding 'check-in needed' keyword so this gets picked up for uplift.
Keywords: checkin-needed
|
||
Comment 7•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•