Closed Bug 1092345 Opened 5 years ago Closed 5 years ago

The keyed histogram section in about:telemetry needs style improvements

Categories

(Toolkit :: Telemetry, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: gfritzsche, Assigned: arky)

References

Details

Attachments

(1 file)

Bug 1092176 added a section for keyed histograms, but the layout is still a bit broken.
Depends on: 1094022
Duplicate of this bug: 1094022
No longer depends on: 1094022
Testing around with arky today shows that adding |overflow: hidden| for the keyed-histograms makes layout sane.
A little surprising for me, but arky may pick this bug up.
Arky has a patch for this coming up, re-assigning.
Assignee: georg.fritzsche → hitmanarky
Status: NEW → ASSIGNED
The simple CSS patch makes the keyed histograms layout consistent.
Attachment #8523500 - Flags: review?(nfroyd)
Comment on attachment 8523500 [details] [diff] [review]
Telemetry-Keyedhistogram-CSS.patch

Review of attachment 8523500 [details] [diff] [review]:
-----------------------------------------------------------------

Given Georg says the layouts are OK, I'm going to trust him.  r=me
Attachment #8523500 - Flags: review?(nfroyd) → review+
Thanks Nathan, Adding 'check-in needed' keyword so this gets picked up for uplift.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/df6c8e880cda
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.