Closed Bug 1092176 Opened 5 years ago Closed 5 years ago

Add keyed histogram section to about:telemetry

Categories

(Toolkit :: Telemetry, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox34 --- fixed
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

Details

Attachments

(2 files)

No description provided.
The section shows up fine, but layout is a little borked:
http://imgur.com/Ah1t4YZ
(In reply to Georg Fritzsche [:gfritzsche] from comment #1)
> The section shows up fine, but layout is a little borked:
> http://imgur.com/Ah1t4YZ

Vladan, could we temporarily live with this?
Flags: needinfo?(vdjeric)
Per IRC this is fine for now.
Flags: needinfo?(vdjeric)
Attachment #8515189 - Flags: review?(nfroyd)
Comment on attachment 8515189 [details] [diff] [review]
Add keyed histograms to about:telemetry

Review of attachment 8515189 [details] [diff] [review]:
-----------------------------------------------------------------

If this shows up with data, I'm happy with it.
Attachment #8515189 - Flags: review?(nfroyd) → review+
Blocks: 1092345
Comment on attachment 8515189 [details] [diff] [review]
Add keyed histograms to about:telemetry

Approval Request Comment
[Feature/regressing bug #]: Search telemetry.
[User impact if declined]: This goes with bug 1069874. No keyed histograms visible in about:telemetry, which is bad for QA, transparency etc.
[Describe test coverage new/current, TBPL]: Manual check.
[Risks and why]: Low, just a medium change to about:telemetry.
[String/UUID change made/needed]: Only one string addition for about:telemetry, which can go untranslated IMO.
Attachment #8515189 - Flags: approval-mozilla-beta?
Attachment #8515189 - Flags: approval-mozilla-aurora?
ni on flod to provide l10n approval for the landing with a string addition for about:telemetry.
Flags: needinfo?(francesco.lodolo)
We do localize about:telemetry

Besides that, adding a string on Aurora and Beta is going to create unnecessary noise on branches, when we already have way too much confusion because of DevEd.

If you really need this patch to fix a serious issue, I'd suggest to have a patch for Aurora and Beta without strings.
Flags: needinfo?(francesco.lodolo)
(In reply to Georg Fritzsche [:gfritzsche] from comment #6)
> [String/UUID change made/needed]: Only one string addition for
> about:telemetry, which can go untranslated IMO.

Just to add one more thought: I'd be much happier with these two bugs riding the trains and being properly localized.

Summary says "No keyed histograms visible in about:telemetry, which is bad for QA, transparency etc.", but to me it seems that you're adding a new feature to about:telemetry. Am I wrong? If so, what is currently broken, and when did it break?
(In reply to Francesco Lodolo [:flod] from comment #9)
> (In reply to Georg Fritzsche [:gfritzsche] from comment #6)
> > [String/UUID change made/needed]: Only one string addition for
> > about:telemetry, which can go untranslated IMO.
> 
> Just to add one more thought: I'd be much happier with these two bugs riding
> the trains and being properly localized.
> 
> Summary says "No keyed histograms visible in about:telemetry, which is bad
> for QA, transparency etc.", but to me it seems that you're adding a new
> feature to about:telemetry. Am I wrong? If so, what is currently broken, and
> when did it break?

We are adding a feature to telemetry that should get uplift to beta. This particular bug is for displaying the data from that feature in a new section in about:telemetry.
Without this addition to about:telemetry it will be much harder to check the data and we don't transparently show the data as we should.

I know that we localize about:telemetry, but i think this isn't exactly a central user-facing feature?
Flags: needinfo?(francesco.lodolo)
As this is just one section title (plus a section title and data field title in the other bug), what do you think about beta/aurora patches that just put the title in directly without the l10n file changes?
Ah, per bug 1086252, comment 9 the above suggestion seems ok?
Will prepare patches accordingly.
Approval Request Comment:
See comment 6. This version just addresses the above l10n concerns by making the strings untranslatable.
Attachment #8515599 - Flags: approval-mozilla-beta?
Attachment #8515599 - Flags: approval-mozilla-aurora?
Attachment #8515189 - Flags: approval-mozilla-beta?
Attachment #8515189 - Flags: approval-mozilla-aurora?
(In reply to Georg Fritzsche [:gfritzsche] from comment #11)
> As this is just one section title (plus a section title and data field title
> in the other bug), what do you think about beta/aurora patches that just put
> the title in directly without the l10n file changes?

I'm OK with this approach for both bugs.
Flags: needinfo?(francesco.lodolo)
https://hg.mozilla.org/mozilla-central/rev/304be83fb3c6
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment on attachment 8515599 [details] [diff] [review]
Aurora/Beta patch: Add keyed histograms to about:telemetry

Approved for Beta and Aurora with hardcoded strings. As an alternative to making untranslatable changes to about:telemetry during Beta, we used to have an about:Telemetry add-on. If this add-on is up-to-date, making the changes there as opposed to in product should allow the required people to see the changes that you've made without impacting about:telemetry for all users.

Vladan - Do we still have the about:telemetry add-on and is it up-to-date?
Flags: needinfo?(vdjeric)
Flags: needinfo?(georg.fritzsche)
Attachment #8515599 - Flags: approval-mozilla-beta?
Attachment #8515599 - Flags: approval-mozilla-beta+
Attachment #8515599 - Flags: approval-mozilla-aurora?
Attachment #8515599 - Flags: approval-mozilla-aurora+
Per vladans blog, the about:telemetry extension was obsoleted by adding the about:telemetry page to the official source.

https://blog.mozilla.org/vdjeric/2012/11/25/new-abouttelemetry-page-in-firefox-19/
Flags: needinfo?(vdjeric)
Flags: needinfo?(georg.fritzsche)
(In reply to Georg Fritzsche [:gfritzsche] from comment #17)
> Per vladans blog, the about:telemetry extension was obsoleted by adding the
> about:telemetry page to the official source.
> 
> https://blog.mozilla.org/vdjeric/2012/11/25/new-abouttelemetry-page-in-
> firefox-19/

Thanks for following up on this. Not a viable alternative then.
What is meant by "keyed", either the keyboard pressed or key/value data?

What is the difference between histogram.
Flags: needinfo?(georg.fritzsche)
Depends on: 1094035
I updated the telemetry documentation to include keyed histograms (key/value store, or rather key/histogram):
https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Adding_a_new_Telemetry_probe
Flags: needinfo?(georg.fritzsche)
No longer depends on: 1094035
You need to log in before you can comment on or make changes to this bug.