Closed Bug 1092430 Opened 5 years ago Closed 5 years ago

Contacts app should follow text selection pattern.

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86
macOS
defect
Not set

Tracking

(feature-b2g:2.2+, ux-b2g:2.2)

VERIFIED FIXED
2.2 S3 (9jan)
feature-b2g 2.2+
ux-b2g 2.2

People

(Reporter: swilkes, Assigned: arcturus)

References

Details

(Whiteboard: [p=4])

Attachments

(3 files)

See Comms pages of attached spec.

User should be able to select text entered in Contacts search field, and user entered (not user *selected*) fields in single contact entry.

* Input fields (input areas, input dialogs and search fields) are the only Building Blocks with selectable text. 

* HTML elements like buttons or links, or events like ontouchstart or onclick, should trigger the action when tapped rather than triggering text selection.
Blocks: gaia-copy-paste
No longer blocks: CopyPasteLegacy
feature-b2g: --- → 2.2?
The Gecko work is close to completion, the remaining part is to fix test case failures then pref it on in m-c bug 1092888. After the bug landed, text selection and cut/copy/paste be triggered in apps on both editable and non-editable elements.

Gaia per app work in v2.2 is to follow UX guideline and leverage CSS -moz-user-select https://developer.mozilla.org/en-US/docs/Web/CSS/user-select to make certain elements non-selectable.

Before Gecko is pref on in m-c, Gaia can manually switch it on by the following two pref to test in advance:
pref("selectioncaret.enabled", on);
pref("selectioncaret.noneditable", on);
Scheduling for next sprint, hopefully we can start even before 2.2
Target Milestone: --- → 2.1 S9 (21Nov)
Assignee: nobody → sergi.mansilla
Whiteboard: [p=4]
This is a 2.2 feature.
feature-b2g: 2.2? → 2.2+
Target Milestone: 2.1 S9 (21Nov) → 2.2 S1 (5dec)
QA Contact: jlorenzo
QA Whiteboard: [2.2-feature-qa+]
Hi Sergi,
Are you actively working on this?
May need to update target milestone to reflect actual plan. 
This feature is still in 2.2 scope.
Flags: needinfo?(sergi.mansilla)
Hi,

we have sync offline and I'll steal this feature from Segi :)
Assignee: sergi.mansilla → francisco
Comment on attachment 8535544 [details] [review]
[PullReq] arcturus:bug-1092430 to mozilla-b2g:master

Hi Sergi,

tiny change, you'll need to add the prefs to your build to enable this.
Attachment #8535544 - Flags: review?(sergi.mansilla)
Comment on attachment 8535544 [details] [review]
[PullReq] arcturus:bug-1092430 to mozilla-b2g:master

Hi :howie!

Right now we just disabled the text selection in the whole document, we realised that (at least with current implementation) text selection is enabled for input fields, that is what contacts needs.

Does this sounds good to you?
Attachment #8535544 - Flags: feedback?(hochang)
Hi Francisco, yes, this sounds great, thank you!
Attachment #8535544 - Flags: feedback?(hochang) → feedback+
Attached image Search result
Hi,
After applying your patch, the contact name in search result should not be selectable.
Flags: needinfo?(francisco)
Flags: needinfo?(francisco)
Target Milestone: 2.2 S1 (5dec) → 2.2 S2 (19dec)
:gduan, thanks, I needed to force no text selection on the search results, now patch is updated.
Comment on attachment 8535544 [details] [review]
[PullReq] arcturus:bug-1092430 to mozilla-b2g:master

LAnded at ad35df88107ab93b85a36f8bad3c772445fab486
Flags: needinfo?(sergi.mansilla)
Attachment #8535544 - Flags: review?(sergi.mansilla) → review+
Asking for Verifyme for qa sing off
Keywords: verifyme
Assigning to Gerry as he's the QA contact for Text Selection in the new 2.2.
Flags: needinfo?(gchang)
Keywords: verifyme
QA Contact: jlorenzo → gchang
Flags: needinfo?(gchang) → needinfo?(edchen)
I will follow up this feature and make sure quality. Thanks.
Flags: needinfo?(edchen)
QA Contact: gchang → edchen
Status: NEW → ASSIGNED
I see r+ but not yet landed. 
Modifying target milestone to S3 and hopefully we can make before branch date.
Target Milestone: 2.2 S2 (19dec) → 2.2 S3 (9jan)
Hi,

this was merged while ago, but we didn't update the bug status.

Landed:
https://github.com/mozilla-b2g/gaia/commit/ad35df88107ab93b85a36f8bad3c772445fab486
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
This bug has been successfully verified on latest Flame v2.2.
See attachment: verified_v2.2.png.
Reproduce rate: 0/5

STR:
1.Open Contacts app with contacts.
2.Tap Search box and then input some letters.
3.Long tap on these letters.
**They can be selected (or copy, paste).

Flame 2.2 build:
Gaia-Rev        d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/be206fa2fb60
Build-ID        20150202002507
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150202.035604
FW-Date         Mon Feb  2 03:56:15 EST 2015
Bootloader      L1TC000118D0
-----------------------------------------------------------------------------
Clear "verifyme".
Status: RESOLVED → VERIFIED
Keywords: verifyme
QA Whiteboard: [2.2-feature-qa+] → [2.2-feature-qa+][MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.