1092538 - Ignore `null` iterable in Map, Set, WeakMap and WeakSet constructors

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[André Bargull [:anba]]

`null` iterable argument has to be ignored.

Simple tests:
---
new Map(null);
new Set(null);
new WeakMap(null); // but see bug 1092537
new WeakSet(null);
---

Expected: No TypeError thrown
Actual: TypeError thrown for Map, Set and WeakSet

Comment 1

[André Bargull [:anba]]

Ignoring `null` in addition to `undefined` was added in ES6 draft rev14.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Ignore `null` iterable in Map, Set, WeakMap and WeakSet constructors.

Green on try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=32181e6fa6c0

Comment 3

[Tom S [:evilpie]]

Comment on attachment 8530324 [details] [diff] [review]
Ignore `null` iterable in Map, Set, WeakMap and WeakSet constructors.

Review of attachment 8530324 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)

::: js/src/builtin/MapObject.cpp
@@ -1235,5 @@
>      if (!obj)
>          return false;
>  
>      CallArgs args = CallArgsFromVp(argc, vp);
> -    if (args.hasDefined(0)) {

please change all of these to !args.get(0).isNullOrUndefined()

Comment 4

[Tooru Fujisawa [:arai]]

thank you for reviewing :D

Changed those lines and pushed to m-i:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/187125e5da10

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/187125e5da10

Comment 6

[Tooru Fujisawa [:arai]]

Updated following documents:
  https://developer.mozilla.org/en-US/Firefox/Releases/37
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakMap
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakSet
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/New_in_JavaScript/ECMAScript_6_support_in_Mozilla

"Site Compatibility for Firefox 37" will be updated after Firefox 37 becomes Aurora.

Comment 7

[Florian Scholz (Open Web Docs)]

Thanks, :arai! :)

Comment 8

[Kohei Yoshino]

Added to the compat doc: https://developer.mozilla.org/en-US/Firefox/Releases/37/Site_Compatibility