Use non-iterable object in browser_console_addonsdk_loader_exception.js.

RESOLVED FIXED in Firefox 37

Status

defect
RESOLVED FIXED
5 years ago
11 months ago

People

(Reporter: arai, Assigned: arai)

Tracking

Trunk
Firefox 37

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
http://hg.mozilla.org/mozilla-central/file/bc2c36dda0a9/browser/devtools/webconsole/test/browser_console_addonsdk_loader_exception.js#l31
>     toolbox._toolPanels = null;
> ...
>    executeSoon(() => {
>      executeSoon(fixToolbox);
>      expectUncaughtException();
>      toolbox.getToolPanels();
>    });
> 
>    let [result] = yield waitForMessages({
>      webconsole: browserconsole,
>      messages: [{
>        text: "TypeError: can't convert null to object",
>        category: CATEGORY_JS,
>        severity: SEVERITY_ERROR,
>      }],
>    });

http://hg.mozilla.org/mozilla-central/file/bc2c36dda0a9/browser/devtools/framework/toolbox.js#l166
>   getToolPanels: function() {
>     return new Map(this._toolPanels);
>   },

When bug 1092538 is fixed, the test will fail because null is a valid argument for Map constructor,
and the exception is not thrown.
(Assignee)

Updated

5 years ago
Blocks: 1092538
Assignee: nobody → arai_a
Status: NEW → ASSIGNED
Comment on attachment 8525540 [details] [diff] [review]
1-Bug_1101704___Use_non_iterable_object_in_browser_console_addonsdk_loader_exception_js_.patch

Review of attachment 8525540 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for your patch. Apologies for the delay, I've been away for a few months.
Attachment #8525540 - Flags: review?(mihai.sucan) → review+
https://hg.mozilla.org/mozilla-central/rev/9902a6ce9831
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.