1101704 - Use non-iterable object in browser_console_addonsdk_loader_exception.js.

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Tooru Fujisawa [:arai]]

http://hg.mozilla.org/mozilla-central/file/bc2c36dda0a9/browser/devtools/webconsole/test/browser_console_addonsdk_loader_exception.js#l31
>     toolbox._toolPanels = null;
> ...
>    executeSoon(() => {
>      executeSoon(fixToolbox);
>      expectUncaughtException();
>      toolbox.getToolPanels();
>    });
> 
>    let [result] = yield waitForMessages({
>      webconsole: browserconsole,
>      messages: [{
>        text: "TypeError: can't convert null to object",
>        category: CATEGORY_JS,
>        severity: SEVERITY_ERROR,
>      }],
>    });

http://hg.mozilla.org/mozilla-central/file/bc2c36dda0a9/browser/devtools/framework/toolbox.js#l166
>   getToolPanels: function() {
>     return new Map(this._toolPanels);
>   },

When bug 1092538 is fixed, the test will fail because null is a valid argument for Map constructor,
and the exception is not thrown.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: 1-Bug_1101704___Use_non_iterable_object_in_browser_console_addonsdk_loader_exception_js_.patch

Used non-iterable object {} instead of null.

Green on try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=cff5e5f8438e

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 8525540 [details] [diff] [review]
1-Bug_1101704___Use_non_iterable_object_in_browser_console_addonsdk_loader_exception_js_.patch

Review of attachment 8525540 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for your patch. Apologies for the delay, I've been away for a few months.

Comment 3

[Tooru Fujisawa [:arai]]

thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/9902a6ce9831

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9902a6ce9831