1092859 - Changing HTML5 video volume alters system mixer settings (WinXP)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Franck (Wip)]

Mozilla/5.0 (Windows NT 5.1; rv:34.0) Gecko/20100101 Firefox/34.0
Built from https://hg.mozilla.org/releases/mozilla-beta/rev/5a44be6667fa (34 beta 5 ?)
Fresh install, new profile, all add-ons disabled and no Flash installed.

Reproducible with Firefox 34 Beta, Aurora 35 and Nightly 36, on Windows XP only.
Not reproducible on Windows 7 or 8.1.

Steps to reproduce:
  - open any Youtube video, since Firefox 34 it should always use the HTML5 player
    (eg. http://www.youtube.com/watch?v=YE7VzlLtp-4)
  - right-click to check the context menu, should be Youtube's one and not Flash's
  - since it is a new profile (no cookie), volume is set to 100%
  - open Windows "Volume Control" panel, check the "Wave" channel level, then close the panel
  - mute the video using the player controls
  - open back the "Volume Control" panel and check again the "Wave" channel level

Actual results:
The "Wave" channel level changed from current OS settings (50% in my case) to 100% then 0%.
In fact, the system mixer level follows the value of the HTML5 video player volume.

Expected results:
The "Wave" channel should not have changed. System settings must not be altered.

It is a regression from Firefox 33.
It is a nuisance exploitable by malwares and bad-behaving ads.

Worse case: opening an OGV video via file association opens Firefox as a player with the volume always set at 100%.

May be related to bug 1046814.

Comment 1

[Matthias Versen [:Matti]]

works for me on windows7 with 34beta and trunk, seems to be WindowsXP only.

Comment 2

[D Merrick]

I'm getting this problem too (eg youtube), it's awful; doesn't happen with Chrome, but does with firefox.
Typically I'll have web video sound down not because it's too loud but because I don't want it to intrude on music I'm listening to; result - my music disappears too. XP SP3.
d

Comment 3

[Matthew Gregan [:kinetik]]

This'll be a regression from bug 1027713, I think.  XP only because later Windows versions use the WASAPI backend in libcubeb but XP uses the WinMM backend.  In the WinMM change for bug 1027713, the new volume API is used if the waveOut supports WAVECAPS_VOLUME, but I suspect that we always need to use soft volume on WinMM because even when WAVECAPS_VOLUME is supported the WinMM volume API adjusts the system PCM device, rather than a per-stream (or even per-app) setting...

Comment 4

[Matthew Gregan [:kinetik]]

Attachment: bug1092859_v0.patch

Simple change: always use soft volume.

No try push yet because the tree is closed.

Comment 5

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ce101f79d242

Comment 6

[Matthew Gregan [:kinetik]]

Franck and D Merrick, if you'd like to test this fix, there should be builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-%20ce101f79d242/ in a few hours.  Thanks!

Comment 7

[Matthew Gregan [:kinetik]]

(In reply to Matthew Gregan [:kinetik] from comment #6)
> Franck and D Merrick, if you'd like to test this fix, there should be builds
> available at

I mean: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-ce101f79d242/

Comment 8

[D Merrick]

Thanks Mat -
Just tried a youtube video (https://www.youtube.com/watch?v=a502RejLz8s) ; at anything other than 100% it makes a terrifying and unlistenable gurgling sound, and it still plays sound even on mute and 0% !!
david

Comment 9

[Matthew Gregan [:kinetik]]

Comment on attachment 8520268 [details] [diff] [review]
bug1092859_v0.patch

Sorry!  Thanks for testing, it looks like there's a bug in the f32 sample format soft volume code.  Simple fix, I'll have a new try push up shortly.

Comment 10

[Matthew Gregan [:kinetik]]

Attachment: bug1092859_v1.patch

Fix type/cast for f32 sample format in soft volume code.

Tested locally, works fine.  Pushed to try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b72ae6dd8ec8

New builds for testing will show up at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-b72ae6dd8ec8/ in a few hours.

Comment 11

[Franck (Wip)]

Sorry for the delay.
I've just tested the second try build (b72ae6dd8ec8try-win32) and it works fine on Windows XP SP3.
Test cases : Youtube videos and drap'n drop of OGV movies.
Sound is OK, changing volume level is effective yet this doesn't alter the system mixer settings.
It's good, thanks.

Comment 12

[Paul Adenot (:padenot)]

Comment on attachment 8520429 [details] [diff] [review]
bug1092859_v1.patch

Review of attachment 8520429 [details] [diff] [review]:
-----------------------------------------------------------------

Hrm, sorry about that.

Comment 13

[Paul Adenot (:padenot)]

Comment on attachment 8520429 [details] [diff] [review]
bug1092859_v1.patch

Review of attachment 8520429 [details] [diff] [review]:
-----------------------------------------------------------------

Hrm, sorry about that.

Comment 14

[D Merrick]

[e-mail]-b72ae6dd8ec8 works good for me too, XP SP3 - thanks greatly for this!
david

Comment 15

[Matthew Gregan [:kinetik]]

Thanks for confirming the patch works!

Landed on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/06771532f99d

Comment 16

[Matthew Gregan [:kinetik]]

Comment on attachment 8520429 [details] [diff] [review]
bug1092859_v1.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1027713
[User impact if declined]: web content can control system audio volume on Windows XP
[Describe test coverage new/current, TBPL]: tested locally and have fix confirmation from others
[Risks and why]: very low risk, fall back to soft volume code
[String/UUID change made/needed]: none

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/06771532f99d

Comment 18

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8520429 [details] [diff] [review]
bug1092859_v1.patch

Although this only landed on m-c recently, it was verified in comment 11 and comment 14. Taking for beta9.

Beta+
Aurora+

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6dc90256d231
https://hg.mozilla.org/releases/mozilla-beta/rev/f2dd9f2a084a