1092894 - [System2] Implement NfcCore

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

NfcCore is responsible to load / launch all Nfc related modules.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: WIP, separate NFC and bluetooth of nfc_handover_manager.js

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8542477 [details]
WIP, separate NFC and bluetooth of nfc_handover_manager.js

Hi Alive,
could I have your feedback on this patch?
After this patch, I would like to refine nfc_handover_manager and nfc_manager.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8542477 [details]
WIP, separate NFC and bluetooth of nfc_handover_manager.js

Well done, just a few things to note.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8542477 [details]
WIP, separate NFC and bluetooth of nfc_handover_manager.js

Hi Alive,
tests added, could I have your review on this patch? Thanks.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8542477 [details]
WIP, separate NFC and bluetooth of nfc_handover_manager.js

There is something to note.

:tauzen, could you help to test to make sure nfc function does not break? Thanks in advance.

Comment 6

[Krzysztof Mioduszewski[:tauzen]]

Tested the most common scenarios and compared them to gaia master. Tag reading, contact sharing/receiving, url sharing/receiving and image sharing work fine. I've found a problem with image receiving scenario. 

It seems that there is some problem with the handover when I'm trying to share an image from Android device to Flame. Image transfer does not start and I'm presented with a prompt on Flame asking for permission to receive the file. Even when I agree to it the transfer fails. This prompt should not be present and image transfer should start immediately. 

Additional (small) problem, enabling NFC enables also debug printouts in nfcManager - this should also be fixed, I guessing this was just a mistake.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks tauzen,
the permission bug is here bug 1124556 (gecko). It's also reproducible in master.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

merge to master:
https://github.com/mozilla-b2g/gaia/commit/5ebbc32fa22773f38be3b24704e5ad64a7ff080e