1129255 - [NFC] Unable to show BT confirm dialog when NFC headset detected

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alison Shiue]

Gaia-Rev        dfebaaa8aab43470f482d09d71137bab840c3ae9
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/0c2f7434c325
Build-ID        20150203160231
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150203.193141
FW-Date         Tue Feb  3 19:31:52 EST 2015
Bootloader      L1TC000118D0

A phone with NFC. and a NFC-capable bluetooth headset

STR:
1. Enable NFC 
2. Tap the phone with NFC-capable bluetooth headset

Expecteed result:
Show BT confirm dialog

Actual result:
Device vibrate but no BT confirm dialog shows

Comment 1

[Alison Shiue]

[Blocking Requested - why for this release]:
Obvious problem

Comment 2

[[e-mail]]

Bug 1125019 fix this issue in 2.2.
Bug 1092894 (NFC Core refactor) include the above fix but might introduce other issue around these dialogs.

Comment 3

[[e-mail]]

The reason is the lazyloader does not work well within ｀nfc_handover_manager.js｀, so the dialogs does not actually loaded into system. 
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/nfc_handover_manager.js#L579

I guess it might be related to how core registry works. I've met the same issue in bt_core for experimental work as well.

Remove the lazyload part and put import back into index.html could fix the problem. 
It's not an elegant solution though. @alive do you have any suggestion?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Fred Lin [:gasolin] from comment #3)
> The reason is the lazyloader does not work well within
> ｀nfc_handover_manager.js｀, so the dialogs does not actually loaded into
> system. 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/
> nfc_handover_manager.js#L579
> 
> I guess it might be related to how core registry works. I've met the same
> issue in bt_core for experimental work as well.
> 
> Remove the lazyload part and put import back into index.html could fix the
> problem. 
> It's not an elegant solution though. @alive do you have any suggestion?

No idea. Please help to debug inside LazyLoader.
I don't think Core will impact LazyLoader though.

Comment 5

[[e-mail]]

The initial LazyLoader tracking shows 'js/nfc_connect_system_dialog.js' always trapped in LazyLoader 'isloading' list and not flow into `perFileCallback` function.

Comment 6

[[e-mail]]

Bug 1092894 cause this issue so no need regressionwindow.

Comment 7

[GitHub Autolander Bot]

Attachment: [PullReq] gasolin:issue-1129255 to mozilla-b2g:master

Comment 8

[[e-mail]]

For this specific case the reason is miss-spelling the `system_nfc_connect_dialog` to `nfc_connect_system_dialog`. 

But in experiment the lazyloader only report error with `/js/system_nfc_connect_dialog` (with prefix /), since the system baseURL is `http://system.gaiamobile.org/index.html`. Without the `/` prefix the result just as comment 5, which is interesting...

Comment 9

[[e-mail]]

Comment on attachment 8561183 [details] [review]
[PullReq] gasolin:issue-1129255 to mozilla-b2g:master

test case added

Comment 10

[[e-mail]]

fixed lint issue then try autoland

thanks!

Comment 11

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 12

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 13

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/6f66af0186d147b331590fe2b2f20d710a744002

Comment 14

[Alison Shiue]

Verified on 

Gaia-Rev        0cf517083f7eb5fc269e1236edba50534f65e3cd
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/2cb22c058add
Build-ID        20150209160204
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150209.193059
FW-Date         Mon Feb  9 19:31:10 EST 2015
Bootloader      L1TC000118D0