1092964 - Cost Control app to follow text selection pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[howie [:howie]]

Attachment: FxOS 2.2 Text Selection Guidelines 03.pdf

* Input fields (input areas, input dialogs and search fields) are the only Building Blocks with selectable text. 

* HTML elements like buttons or links, or events like ontouchstart or onclick, should trigger the action when tapped rather than triggering text selection.

Comment 1

[howie [:howie]]

The Gecko work is close to completion, the remaining part is to fix test case failures then pref it on in m-c bug 1092888. After the bug landed, text selection and cut/copy/paste can be triggered in apps on both editable and non-editable elements.

Gaia per app work in v2.2 is to follow UX guideline and leverage CSS -moz-user-select https://developer.mozilla.org/en-US/docs/Web/CSS/user-select to make certain elements non-selectable.

Before Gecko is pref on in m-c, Gaia can manually switch it on by the following two pref to test in advance:
pref("selectioncaret.enabled", on);
pref("selectioncaret.noneditable", on);

Comment 2

[Peter Dolanjski [:pdol]]

I'm not sure that any part of the Cost Control components need to have text selection.  I can't see any use cases for it.

Omega/Harley, what do you think?

If there is nothing to do, let's close this bug.

Comment 3

[Omega Feng [:Omega] [:馮於懋]]

I've scanned Juwei's spec and found nothing special needs text selection expect text inputs. However I don't think we should close this bug now, as I know devs still have some works to do to follow the guidelines.

Comment 4

[Harly Hsu[:harly]]

Agree with Omega on comment 3. We should still keep this bug open until we are sure that everything is working properly for text selection in Cost Control.

Comment 5

[howie [:howie]]

This is a 2.2 feature.

Comment 6

[Jacob Shen]

[Tracking Requested - why for this release]:

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

(In reply to jshen from comment #6)
> [Tracking Requested - why for this release]:
Hi Jacob,
Just saw you removed the feature-b2g:2.2. 
I know we won't do smart data in 2.2 but I think copy-n-paste is still needed. 
Or, there's no effort at all for this bug?

Comment 8

[howie [:howie]]

There should be few effort on this. The text selection is now enabled by default (if you long press on a word, cut/copy/paste bubble and selection caret shows), so CSS -moz-user-select:none need to be added to elements that are non-selectable.

Feel free to refer to other app's patch, e.g. bug 1092430 , thanks.

Comment 9

[Jacob Shen]

Juwei, please comment.  It's both Peter's and Francisco's finding that nothing in the cost control app should be selectable.  Thanks.

Comment 10

[Juwei Huang[:juwei]]

Hi all,
Checked with Harly & Omega, all the text in cost control app is non-selectable.

Comment 11

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Hi Salva,
Do you know who can take this bug?
Branch date is jan12 (though we'll accept uplift), so I would like to make sure there's someone taking care of it shortly.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Salva, in this case cost control app doesn't have any text to be selected, as per the guidelines we got.

So basically we are talking about disabling the selection for the whole app,

-moz-user-select: none

should be enough (perhaps not xD), applied to the html tag.

Comment 13

[GitHub Autolander Bot]

Attachment: [PullReq] lodr:bug-1092964-disable-selection to mozilla-b2g:master

Comment 14

[Salvador de la Puente González [:salva]]

Comment on attachment 8538439 [details] [review]
[PullReq] lodr:bug-1092964-disable-selection to mozilla-b2g:master

Adding some -moz-user-select: none to make all the text (but text inputs) in Cost Control application non selectable. It was not as easy as Francisco said due to the absolutely positioned elements.

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

;) but easy enough

Thanks Salva!

Comment 16

[Marina Rodríguez [:mai]]

Comment on attachment 8538439 [details] [review]
[PullReq] lodr:bug-1092964-disable-selection to mozilla-b2g:master

LGTM, Thanks Salva r+

Comment 17

[howie [:howie]]

Hi Salva, can you help to land this? Thanks!

Comment 18

[Salvador de la Puente González [:salva]]

Rebased and waiting for treeherder.

Comment 19

[Salvador de la Puente González [:salva]]

master: fa5d6a134d76c401902a1549b06877d8e420643e