We agreed that demos staged as part of the Fx 10th anniversary that are proprietary should have a tag explaining that. 1) Let's put words to the tag (:alispivak?) 2) Let's get the tag into the code
Note: we should change the content and the style of the #source .license element to clearly indicate the code is licensed under the creator's EULA. The markup is here: https://github.com/mozilla/kuma/blob/0d586c4e523128eb058ec527d2506df93efb33a8/kuma/demos/templates/demos/detail.html#L276-L280
Depends on: 1093348
:hoosteeno - what's the goal here? we can effectively find & visually explain proprietary demos based on the license_name = 'author' we're adding in bug 1093348. What else do we need to do that requires a tag? Or can we drop the tag requirement?
(In reply to Luke Crouch [:groovecoder] from comment #2) > :hoosteeno - what's the goal here? we can effectively find & visually > explain proprietary demos based on the license_name = 'author' we're adding > in bug 1093348. What else do we need to do that requires a tag? Or can we > drop the tag requirement? If the license work includes visual cues that will help users understand how these demos are different, then I don't think we need a new tag. If we go with a tag, I would suggest, "Proprietary".
This is the visual cue of the existant license work: http://screencast.com/t/QsqSl5Mh We could potentially add additional styling for #source .license .author to make it more eye-catching.
Looks good. 2 changes to request: 1) Can we make it "Author's" rather than "Author"? 2) I think we should trigger some template logic based on that Author's license: If using Author's license, in the "More About This Demo From The Author" section, add text indicating the proprietary nature of this demo. Suggested text: “This demo is released under the Author’s EULA. Its source code is proprietary.” :alispivak, can you vet the text?
Text looks fine to me.
See Also: → bug 1093348
Summary: Create a new tag for "source unavailable" demos → Create visual indicators or explanation on proprietary demos uploaded using author's EULA
How about "This demo is released under the Author’s EULA. It includes proprietary source code."? Not all of the source code will be proprietary.
Good point. +1 to your version, :openjck.
Or maybe more accurately, "proprietary software." The term "proprietary source code" doesn't make much sense.
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/52acbb043e6c3a3af7c01a498791a8627bca7775 bug 1093309 - Add Author EULA text to demo detail https://github.com/mozilla/kuma/commit/3fa4ff94f08e116e9b6e5e4c341c71b06ab9130d Merge pull request #2893 from darkwing/tag-1093309-text bug 1093309 - Add Author EULA text to demo detail
:hoosteeno - the commit seems to have fixed this bug, even though it didn't have "fix bug" in front. Does it look good now?
I do not see the text in comments 7/8 at the top of the information box. Is it PR'd?
Oh -- nevermind. It landed in "About this demo", while the bug asked for it to land in "More About This Demo From The Author". I think that's fine.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.