1093366 - [3rd party][MarketPlace]App cannot be closed from card view

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[ver4ffos]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141102030204

Steps to reproduce:

Flame device

1. Search Music graph app in market place and install.
2. Open music graph app from market place or homescreen.
3. search and play some music.
4. Long press home button.
5. Close Music graph app from cardview.
6. Check card view again and close Music Graph app(can be repeated many times)
7. From homescreen try to launch Music graph.


Actual results:

1. At step 6, Music Graph app is not closed. Every-time app is shown in card view.
2. At step 7 app is not launched. Device needs to restart. 


Expected results:

App should be closed properly, should not be shown in card view.
App should be launched again properly.

Comment 1

[ver4ffos]

Attachment: youtube link

Comment 2

[Rachelle Yang [:ryang][[e-mail]]]

Hi Etienne, would you mind helping with this to check if this is a card view defect?
to be noted, this happened on Flame 2.0.
Thank you very much !

Comment 3

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

easy one :)

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8522949 [details] [review]
Gaia PR

\O/

Comment 5

[Etienne Segonzac (:etienne)]

Should we land this on 2.0? Is it for a partner branch?

Comment 6

[Rachelle Yang [:ryang][[e-mail]]]

Hi ver4ffos,

Could you please help us check if App cannot be closed from card view only happened for certain specific apps ? or only on Music graph app ? 


thank you very much!

Comment 7

[ver4ffos]

Dear Rachelle,

I found this issue only with Music graph app.
I have checked many other apps but did not happened.

Comment 8

[Rachelle Yang [:ryang][[e-mail]]]

Hi ver4ffos,

thank you very much for your confirmation.

Comment 9

[Wesly Huang (EPM)]

[Triage] de-nom for 2.0 considering current phase, however should land to m/c for future releases.

@Etienne: Much appreciate for your effort on it! I think partner can get the patch and integrate by themselves but we tend to minimize the change on 2.0, instead please help put in on m/c for the future SWs. Thank you!

Comment 10

[Etienne Segonzac (:etienne)]

It's already fixed on master. So should we close this?

Comment 11

[bhavana bajaj [:bajaj]]

eitenne, can you please submit an approval for 2.0/2.1 here ?

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8522949 [details] [review]
Gaia PR

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: some apps can break the cardview when they're closed (because the WindowManager errors while closing)
[Testing completed]: the STRs from the bug + the basic card view scenarios
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: none

Comment 13

[Ryan VanderMeulen [:RyanVM]]

What about v2.1? Also, where's the changeset link for master?

Comment 14

[Etienne Segonzac (:etienne)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #13)
> What about v2.1? Also, where's the changeset link for master?

Sorry for the confusion, this fix is 2.0 only.
When I said "already fixed" on master I meant by another patch (probably bug 1039519).

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Thanks for clarifying.

v2.0: https://github.com/mozilla-b2g/gaia/commit/348e8be961a5219ebed35c52e1f6f009985108ef