1093530 - [Stingray][System] make inline activity be transparent in background

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

We may need to make inline activity iframe to be transparent and let app itself to decide if it wants to be transparent or not.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch to enable transparent inline activity

The UX spec of smart-settings requires semi-transparent on top of its opener which will be smart-home. And in some cases, we need to make it totally transparent. So, we use inline activity to achieve that. The is the patch to let inline activity have transparent background.

Rex,

Please review this patch.

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8523773 [details] [review]
patch to enable transparent inline activity

Looks good to me.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Sorry, I had changed my mind. To prevent mis-using, I will introduce a white list with transparent background for "smart-settings" app and to allow it to have the ability to have transparent background.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8523773 [details] [review]
patch to enable transparent inline activity

Rex,

Sorry, I had changed the PR to limit only smart settings to have transparent background. Please review this version.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8523773 [details] [review]
patch to enable transparent inline activity

Looks ok to me.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/9c55fffae07deed9c1ce6d9ab2f666e9f82cbcb5

gaia try is all green
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=c68b336153ce