109354 - Attachment link on newly entered bug refers to old form

Status: VERIFIED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P1)

Description

[[e-mail]]

Steps to reproduce problem:
1. Enter a new bug
2. Click on the "attach a file to this bug" link

Actual results: old attachment screen

Expected results: new create attachment screen as per link on bug form

Comment 1

[timeless]

Attachment: fix

Comment 2

[Gervase Markham [:gerv]]

The best solution is to redirect people if the attachment tracker is turned on.
If we ever remove the old interface, these files will just redirect
unconditionally. We can't remove them from CVS because of links and bookmarks
and stuff.

Patch coming up.

Gerv

Comment 3

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Add cacheable permanent redirects to createattachment.cgi and
showattachment.cgi.

Gerv

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 57529 [details] [diff] [review]
Patch v.1

The attachment tracker is becoming the default attachment interface per bug
104521.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 57528 [details] [diff] [review]
fix

works, trival.	r=myk, no second review needed.

Comment 6

[Bradley Baetz (:bbaetz)]

Yes, but there are old links refering to these existing urls. Wehn the
attachment tracker becomes the default, just remove the if, and the rest of the
file.

Theres still changepassword.cgi, and I would assume that far less people have
urls pointing to that (not the mention that that code should be doing a
redirect, too)

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 57529 [details] [diff] [review]
Patch v.1

D'oh.  My mistake.  I didn't read closely enough.  Ok, I agree with the
redirect, but we should make it unconditional now since bug 104521 is going
into CVS in the 2.16 timeframe.

Comment 8

[[e-mail]]

Surely you need both patches, one so that new bugs work correctly without
needing to redirect and one to handle bookmarks that need redirecting?

Comment 9

[Bernd]

This bug has a bad side effect, if you hit the old attachment cgi you can't
create a attachment to the bug. You will get a red box that your file path is
either not correct or the attached file is empty. Could you please  place a
notation on the page that this cgi is currently not working.

Comment 10

[Matthew Tuck [:CodeMachine]]

I understand the old show attachment CGI being in bookmarks, but I can't see how
someone would ever get to the old create attachment CGI.  It never worked
without parameters, and I don't see a bookmark to attaching on a specific bug as
being useful.

Comment 11

[[e-mail]]

Matthew Tuck wrote:

> I can't see how someone would ever get to the old create attachment CGI.

From the attachment link on a newly entered bug, perhaps?

Comment 12

[Matthew Tuck [:CodeMachine]]

That would go to the new create attachment CGI, once this is fixed.  My point is
I don't see why we need a backward compatability CGI for it.

Comment 13

[[e-mail]]

Well this is the bug to fix the link on the newly entered bug.

If anyone wants to discuss redirecting createattachment.cgi use bug 109480.

If it's likely that people have bookmarks to showattachment.cgi, file a new bug.

Comment 14

[Matthew Tuck [:CodeMachine]]

There is existing discussion here of that which I'm replying to.  I can't very
well reply to it on the other bug, whether it should have been here in the first
place or not.

Comment 15

[Dave Miller [:justdave]]

Attachment 57528 [details] [diff] checked in:

/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.37; previous revision: 1.36

Attachment 57529 [details] [diff] belongs on bug 104521 or bug 109480

Comment 16

[Jacob Steenhagen]

*** Bug 114282 has been marked as a duplicate of this bug. ***

Comment 17

[Dave Miller [:justdave]]

*** Bug 116092 has been marked as a duplicate of this bug. ***

Comment 18

[Dave Miller [:justdave]]

*** Bug 116740 has been marked as a duplicate of this bug. ***

Comment 19

[Vladimir Ermakov]

This is still failing...

Comment 20

[Dave Miller [:justdave]]

Where, on bugzilla.mozilla.org?  That's because b.m.o hasn't picked up the fix
for this yet.  If you're running code checked out of CVS, and this is failing on
your local copy, please reopen again.  If you're complaining about
bugzilla.mozilla.org, file a new bug in the mozilla.org product or wait for them
to update again.  This is fixed in CVS.

Comment 21

[Dave Miller [:justdave]]

*** Bug 119293 has been marked as a duplicate of this bug. ***

Comment 22

[Jacob Steenhagen]

*** Bug 120079 has been marked as a duplicate of this bug. ***

Comment 23

[Myk Melez [:myk] [@mykmelez]]

Attachment 57528 [details] [diff] has now been applied to b.m.o.

If anyone else has problems applying it, note that the patch file contains DOS
line feed characters, which may choke up some versions of "patch".

Comment 24

[[e-mail]]

Just tried this, and it works, so marking verified.