Closed
Bug 1093584
Opened 10 years ago
Closed 10 years ago
Consider returning waffles directly in fireplace index.html, as data attribute
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
2014-11-11
People
(Reporter: mat, Assigned: mat)
References
Details
(Keywords: perf)
Similar to the idea of having region as a data attribute to avoid the consumer_info API call in some cases (bug 1082855), having the waffles directly loaded from index.html would speed up the website and the iframed app, clients wouldn't need to call the site_config API.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mpillard
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Fixed in https://github.com/mozilla/fireplace/commit/c0b0ff6bffa87dc37ded09cee1c15fac182027ae and https://github.com/mozilla/commonplace/commit/478016496416aff19d0c666aefba0311b2ef8e24
STR:
- With developer tools network tab opened, open Marketplace consumer pages
- Verify that no XHR call is made to /api/v2/services/config/site/?... (*)
(*) It would in a true packaged app, but we aren't distributing that yet.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-11-11
Comment 3•10 years ago
|
||
Verified as fixed in marketplace-dev.allizom.org
There is no call to /api/v2/services/config/site/?...
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•