1093621 - Enable new tablet UI by default on Nightly/Aurora

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

The UI structure is in place now. Time to get wider feedback.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Enable new tablet UI by default in Nightly (r=mcomella)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8516728 [details] [diff] [review]
Enable new tablet UI by default in Nightly (r=mcomella)

Here we go.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8516728 [details] [diff] [review]
Enable new tablet UI by default in Nightly (r=mcomella)

Review of attachment 8516728 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/NewTabletUI.java
@@ +11,5 @@
>  import org.mozilla.gecko.preferences.GeckoPreferences;
>  import org.mozilla.gecko.util.HardwareUtils;
>  
>  public class NewTabletUI {
>      // This value should be in sync with preferences_display.xml.

Add to this comment to mention how "being in sync" makes sense despite the fact that this is not "true", i.e. what you told me IRL about how the preference is removed in release builds.

Comment 4

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/3b36af7151ec

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

This may have caused a regression:

Regression: Fx-Team - Robocop Checkerboarding Real User Benchmark - Android 4.0.4 - 65.9% increase
--------------------------------------------------------------------------------------------------
    Previous: avg 17.092 stddev 1.432 of 12 runs up to revision fb567390cb92
    New     : avg 28.347 stddev 0.242 of 12 runs since revision 3b36af7151ec
    Change  : +11.255 (65.9% / z=7.862)
    Graph   : http://mzl.la/1sfsKk0

Changeset range: http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=fb567390cb92&tochange=3b36af7151ec

Comment 6

[Lucas Rocha (:lucasr)]

Backed out due to talos regressions:
https://hg.mozilla.org/integration/fx-team/rev/e7488d6c9af8

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/e7488d6c9af8

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3b36af7151ec

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

This was backed out

Comment 10

[Lucas Rocha (:lucasr)]

Patches from bug 1093621 fix the talos regression. Let's try this again:
https://hg.mozilla.org/integration/fx-team/rev/7ef4eeeace2e

Comment 11

[Gian-Carlo Pascutto [:gcp]]

(In reply to Lucas Rocha (:lucasr) from comment #10)
> Patches from bug 1093621 fix the talos regression. 

Wrong bug nr.

Comment 12

[Lucas Rocha (:lucasr)]

I meant bug 1091519.

Comment 13

[Lucas Rocha (:lucasr)]

Backed out again, talos regressions still there.
https://hg.mozilla.org/integration/fx-team/rev/fc30354927a2

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7ef4eeeace2e

Comment 15

[Ryan VanderMeulen [:RyanVM]]

dammit

Comment 16

[Lucas Rocha (:lucasr)]

Quick update: I narrowed down the cause of the regression. It seems the affected talos test doesn't like the fact that we change the toolbar height in the new tablet UI:

http://dxr.mozilla.org/mozilla-central/source/mobile/android/base/toolbar/ActionBarViewFlipper.java#32

Working on a patch now.

Comment 17

[Lucas Rocha (:lucasr)]

Patch is bug 1097316 works around the regression. I'll continue investigating the real cause of the regression in bug 1097318.

https://hg.mozilla.org/integration/fx-team/rev/b8490f38c4da

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b8490f38c4da

Comment 19

[Aaron Train [:aaronmt]]

Forgot to remove the toast notification I think, see above bug.