1093636 - Define @color/new_tablet_tab_item_title

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

@color/new_tablet_tab_item_title isn't defined

Comment 1

[Martyn Haigh (:mhaigh)]

new_tablet_tab_item_title is defined in : mobile/android/base/newtablet/res/color-large-v11/new_tablet_tab_item_title.xml

Comment 2

[Richard Newman [:rnewman]]

What branch are you working in? Because that's not true on m-c or fx-team.


http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/newtablet/res/color-large-v11/new_tablet_tab_item_title.xml

1 <?xml version="1.0" encoding="utf-8"?>
2 <selector xmlns:android="http://schemas.android.com/apk/res/android">
3 
4     <item android:state_checked="true"
5           android:color="@color/text_color_primary_inverse"/>
6 
7     <item android:state_pressed="true"
8           android:color="@color/text_color_primary_inverse"/>
9 
10     <item android:color="@color/new_tablet_tab_grid_text_unselected"/>
11 
12 </selector>


http://mxr.mozilla.org/mozilla-central/search?string=new_tablet_tab_item_title

Found one matching line
/mobile/android/base/resources/layout/new_tablet_tabs_item_cell.xml (View Hg log or Hg annotations)

    line 30 -- android:textColor="@color/new_tablet_tab_item_title"

Comment 3

[Martyn Haigh (:mhaigh)]

That file is the colour definition - that it exists means that it's defined.  

It's only referenced from new_tablet_tabs_item_cell.xml which is only called from new tablet code, so no chance of a non tablet use, so it's good to stay in the current directory (newtablet/res/color-large-v11).

I don't think anything needs to be done to this.

Comment 4

[Richard Newman [:rnewman]]

Gotcha!